RocketChat/Rocket.Chat

View on GitHub
packages/web-ui-registration/src/RegisterForm.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function RegisterForm has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

export const RegisterForm = ({ setLoginRoute }: { setLoginRoute: DispatchLoginRouter }): ReactElement => {
    const { t } = useTranslation();

    const requireNameForRegister = Boolean(useSetting('Accounts_RequireNameForSignUp'));
    const requiresPasswordConfirmation = useSetting('Accounts_RequirePasswordConfirmation');
Severity: Minor
Found in packages/web-ui-registration/src/RegisterForm.tsx - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File RegisterForm.tsx has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable complexity */
import {
    FieldGroup,
    TextInput,
    Field,
Severity: Minor
Found in packages/web-ui-registration/src/RegisterForm.tsx - About 2 hrs to fix

    Similar blocks of code found in 20 locations. Consider refactoring.
    Open

                            {errors?.password && (
                                <FieldError aria-live='assertive' id={`${passwordId}-error`}>
                                    {errors.password.message}
                                </FieldError>
                            )}
    Severity: Major
    Found in packages/web-ui-registration/src/RegisterForm.tsx and 19 other locations - About 1 hr to fix
    apps/meteor/client/sidebar/header/CreateTeam/CreateTeamModal.tsx on lines 187..191
    apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 216..220
    apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 294..298
    apps/meteor/client/views/account/security/ChangePassword.tsx on lines 74..78
    apps/meteor/client/views/admin/integrations/incoming/IncomingWebhookForm.tsx on lines 219..223
    apps/meteor/client/views/admin/rooms/EditRoom.tsx on lines 173..177
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 204..208
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 230..234
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 259..263
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 295..299
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 322..326
    apps/meteor/client/views/admin/users/AdminUserForm.tsx on lines 363..367
    apps/meteor/client/views/omnichannel/customFields/EditCustomFields.tsx on lines 130..134
    apps/meteor/client/views/omnichannel/customFields/EditCustomFields.tsx on lines 156..160
    apps/meteor/client/views/room/contextualBar/ExportMessages/MailExportForm.tsx on lines 190..194
    apps/meteor/ee/client/omnichannel/additionalForms/BusinessHoursMultiple.tsx on lines 51..55
    apps/meteor/ee/client/omnichannel/cannedResponses/components/cannedResponseForm.tsx on lines 58..62
    apps/meteor/ee/client/omnichannel/cannedResponses/components/cannedResponseForm.tsx on lines 94..98
    packages/web-ui-registration/src/ResetPassword/ResetPasswordPage.tsx on lines 111..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

                            {errors.name && (
                                <FieldError aria-live='assertive' id={`${nameId}-error`}>
                                    {errors.name.message}
                                </FieldError>
                            )}
    Severity: Major
    Found in packages/web-ui-registration/src/RegisterForm.tsx and 17 other locations - About 1 hr to fix
    apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 137..141
    apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 175..179
    apps/meteor/client/sidebar/header/CreateChannel/CreateChannelModal.tsx on lines 229..233
    apps/meteor/client/sidebar/header/CreateDirectMessage.tsx on lines 81..85
    apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 183..187
    apps/meteor/client/views/account/security/ChangePassword.tsx on lines 104..108
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 95..99
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 148..152
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 172..176
    apps/meteor/ee/client/omnichannel/additionalForms/CustomFieldsAdditionalForm.tsx on lines 93..97
    packages/web-ui-registration/src/LoginForm.tsx on lines 174..178
    packages/web-ui-registration/src/LoginForm.tsx on lines 196..200
    packages/web-ui-registration/src/RegisterForm.tsx on lines 181..185
    packages/web-ui-registration/src/RegisterForm.tsx on lines 204..208
    packages/web-ui-registration/src/RegisterForm.tsx on lines 256..260
    packages/web-ui-registration/src/RegisterForm.tsx on lines 280..284
    packages/web-ui-registration/src/ResetPasswordForm.tsx on lines 73..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

                                {errors.passwordConfirmation && (
                                    <FieldError aria-live='assertive' id={`${passwordConfirmationId}-error`}>
                                        {errors.passwordConfirmation.message}
                                    </FieldError>
                                )}
    Severity: Major
    Found in packages/web-ui-registration/src/RegisterForm.tsx and 17 other locations - About 1 hr to fix
    apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 137..141
    apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 175..179
    apps/meteor/client/sidebar/header/CreateChannel/CreateChannelModal.tsx on lines 229..233
    apps/meteor/client/sidebar/header/CreateDirectMessage.tsx on lines 81..85
    apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 183..187
    apps/meteor/client/views/account/security/ChangePassword.tsx on lines 104..108
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 95..99
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 148..152
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 172..176
    apps/meteor/ee/client/omnichannel/additionalForms/CustomFieldsAdditionalForm.tsx on lines 93..97
    packages/web-ui-registration/src/LoginForm.tsx on lines 174..178
    packages/web-ui-registration/src/LoginForm.tsx on lines 196..200
    packages/web-ui-registration/src/RegisterForm.tsx on lines 154..158
    packages/web-ui-registration/src/RegisterForm.tsx on lines 181..185
    packages/web-ui-registration/src/RegisterForm.tsx on lines 204..208
    packages/web-ui-registration/src/RegisterForm.tsx on lines 280..284
    packages/web-ui-registration/src/ResetPasswordForm.tsx on lines 73..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

                            {errors.email && (
                                <FieldError aria-live='assertive' id={`${emailId}-error`}>
                                    {errors.email.message}
                                </FieldError>
                            )}
    Severity: Major
    Found in packages/web-ui-registration/src/RegisterForm.tsx and 17 other locations - About 1 hr to fix
    apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 137..141
    apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 175..179
    apps/meteor/client/sidebar/header/CreateChannel/CreateChannelModal.tsx on lines 229..233
    apps/meteor/client/sidebar/header/CreateDirectMessage.tsx on lines 81..85
    apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 183..187
    apps/meteor/client/views/account/security/ChangePassword.tsx on lines 104..108
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 95..99
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 148..152
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 172..176
    apps/meteor/ee/client/omnichannel/additionalForms/CustomFieldsAdditionalForm.tsx on lines 93..97
    packages/web-ui-registration/src/LoginForm.tsx on lines 174..178
    packages/web-ui-registration/src/LoginForm.tsx on lines 196..200
    packages/web-ui-registration/src/RegisterForm.tsx on lines 154..158
    packages/web-ui-registration/src/RegisterForm.tsx on lines 204..208
    packages/web-ui-registration/src/RegisterForm.tsx on lines 256..260
    packages/web-ui-registration/src/RegisterForm.tsx on lines 280..284
    packages/web-ui-registration/src/ResetPasswordForm.tsx on lines 73..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

                                {errors.reason && (
                                    <FieldError aria-live='assertive' id={`${reasonId}-error`}>
                                        {errors.reason.message}
                                    </FieldError>
                                )}
    Severity: Major
    Found in packages/web-ui-registration/src/RegisterForm.tsx and 17 other locations - About 1 hr to fix
    apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 137..141
    apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 175..179
    apps/meteor/client/sidebar/header/CreateChannel/CreateChannelModal.tsx on lines 229..233
    apps/meteor/client/sidebar/header/CreateDirectMessage.tsx on lines 81..85
    apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 183..187
    apps/meteor/client/views/account/security/ChangePassword.tsx on lines 104..108
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 95..99
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 148..152
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 172..176
    apps/meteor/ee/client/omnichannel/additionalForms/CustomFieldsAdditionalForm.tsx on lines 93..97
    packages/web-ui-registration/src/LoginForm.tsx on lines 174..178
    packages/web-ui-registration/src/LoginForm.tsx on lines 196..200
    packages/web-ui-registration/src/RegisterForm.tsx on lines 154..158
    packages/web-ui-registration/src/RegisterForm.tsx on lines 181..185
    packages/web-ui-registration/src/RegisterForm.tsx on lines 204..208
    packages/web-ui-registration/src/RegisterForm.tsx on lines 256..260
    packages/web-ui-registration/src/ResetPasswordForm.tsx on lines 73..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

                            {errors.username && (
                                <FieldError aria-live='assertive' id={`${usernameId}-error`}>
                                    {errors.username.message}
                                </FieldError>
                            )}
    Severity: Major
    Found in packages/web-ui-registration/src/RegisterForm.tsx and 17 other locations - About 1 hr to fix
    apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 137..141
    apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx on lines 175..179
    apps/meteor/client/sidebar/header/CreateChannel/CreateChannelModal.tsx on lines 229..233
    apps/meteor/client/sidebar/header/CreateDirectMessage.tsx on lines 81..85
    apps/meteor/client/views/account/profile/AccountProfileForm.tsx on lines 183..187
    apps/meteor/client/views/account/security/ChangePassword.tsx on lines 104..108
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 95..99
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 148..152
    apps/meteor/client/views/admin/mailer/MailerPage.tsx on lines 172..176
    apps/meteor/ee/client/omnichannel/additionalForms/CustomFieldsAdditionalForm.tsx on lines 93..97
    packages/web-ui-registration/src/LoginForm.tsx on lines 174..178
    packages/web-ui-registration/src/LoginForm.tsx on lines 196..200
    packages/web-ui-registration/src/RegisterForm.tsx on lines 154..158
    packages/web-ui-registration/src/RegisterForm.tsx on lines 181..185
    packages/web-ui-registration/src/RegisterForm.tsx on lines 256..260
    packages/web-ui-registration/src/RegisterForm.tsx on lines 280..284
    packages/web-ui-registration/src/ResetPasswordForm.tsx on lines 73..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                <Form.Header>
                    <Form.Title id={formLabelId}>{t('registration.component.form.createAnAccount')}</Form.Title>
                </Form.Header>
    Severity: Major
    Found in packages/web-ui-registration/src/RegisterForm.tsx and 3 other locations - About 55 mins to fix
    apps/meteor/client/views/oauth/components/AuthorizationFormPage.tsx on lines 56..58
    packages/web-ui-registration/src/LoginForm.tsx on lines 151..153
    packages/web-ui-registration/src/ResetPasswordForm.tsx on lines 47..49

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                    <ActionLink
                        onClick={(): void => {
                            setLoginRoute('login');
                        }}
                    >
    Severity: Minor
    Found in packages/web-ui-registration/src/RegisterForm.tsx and 1 other location - About 55 mins to fix
    packages/web-ui-registration/src/RegisterFormDisabled.tsx on lines 25..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (errors.email?.type === 'invalid-email') {
            return <EmailConfirmationForm onBackToLogin={() => clearErrors('email')} email={getValues('email')} />;
        }
    Severity: Minor
    Found in packages/web-ui-registration/src/RegisterForm.tsx and 1 other location - About 55 mins to fix
    packages/web-ui-registration/src/LoginForm.tsx on lines 139..141

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        if ([error.error, error.errorType].includes('error-invalid-email')) {
                            setError('email', { type: 'invalid-email', message: t('registration.component.form.invalidEmail') });
                        }
    Severity: Minor
    Found in packages/web-ui-registration/src/RegisterForm.tsx and 1 other location - About 40 mins to fix
    packages/web-ui-registration/src/LoginForm.tsx on lines 92..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status