Sign upLogin

RolandJansen/intermix.js

View on GitHub
Star
src/store/rootReducer.ts

Summary

Maintainability
D
2 days
Test Coverage
F
55%

Function rootReducer has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const rootReducer = (state: IState = initialState, action: AnyAction): IState => {
    if (action.type === ADD_PLUGIN) {
        if (isStringArray(state.plugins)) {
            const newPluginRefs = addItem(state.plugins, action.payload);
            const newState: IState = { ...state, plugins: newPluginRefs };
Severity: Major
Found in src/store/rootReducer.ts - About 2 hrs to fix

    Function rootReducer has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    const rootReducer = (state: IState = initialState, action: AnyAction): IState => {
    if (action.type === ADD_PLUGIN) {
        if (isStringArray(state.plugins)) {
            const newPluginRefs = addItem(state.plugins, action.payload);
            const newState: IState = { ...state, plugins: newPluginRefs };
    Severity: Minor
    Found in src/store/rootReducer.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

        } else if (action.type === CONNECT_AUDIO_NODES) {
        const outEndpoint: AudioEndpoint = [action.payload[0], action.payload[1]];
        const inEndpoint: AudioEndpoint = [action.payload[2], action.payload[3]];

        // we also have to change the state of the former input
    Severity: Major
    Found in src/store/rootReducer.ts - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  if (value === partRef) {
                newState.seqparts.splice(index, 1);
            }
      Severity: Major
      Found in src/store/rootReducer.ts - About 45 mins to fix

        Avoid too many return statements within this function.
        Open

                return state;
        Severity: Major
        Found in src/store/rootReducer.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return state;
          Severity: Major
          Found in src/store/rootReducer.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return newState;
            Severity: Major
            Found in src/store/rootReducer.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return state;
              Severity: Major
              Found in src/store/rootReducer.ts - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    } else if (action.type === REMOVE_PART) {
        const newState = JSON.parse(JSON.stringify(state));
        const partRef = action.payload as string;
        (newState.seqparts as string[]).forEach((value, index) => {
            if (value === partRef) {
                Severity: Major
                Found in src/store/rootReducer.ts and 1 other location - About 3 hrs to fix
                src/store/rootReducer.ts on lines 18..72

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 109.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    } else if (action.type === REMOVE_PLUGIN) {
        const newState = JSON.parse(JSON.stringify(state));
        const pluginRef = action.payload as string;
        (newState.plugins as string[]).forEach((value, index) => {
            if (value === pluginRef) {
                Severity: Major
                Found in src/store/rootReducer.ts and 1 other location - About 3 hrs to fix
                src/store/rootReducer.ts on lines 35..72

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 109.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    } else if (action.type === ADD_PART) {
        if (isStringArray(state.seqparts)) {
            const newPartRefs = addItem(state.seqparts, action.payload);
            const newState: IState = { ...state, seqparts: newPartRefs };
            return newState;
                Severity: Major
                Found in src/store/rootReducer.ts and 1 other location - About 1 hr to fix
                src/store/rootReducer.ts on lines 11..72

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 67.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (action.type === ADD_PLUGIN) {
        if (isStringArray(state.plugins)) {
            const newPluginRefs = addItem(state.plugins, action.payload);
            const newState: IState = { ...state, plugins: newPluginRefs };
            return newState;
                Severity: Major
                Found in src/store/rootReducer.ts and 1 other location - About 1 hr to fix
                src/store/rootReducer.ts on lines 28..72

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 67.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                const isPluginState = (value: unknown): value is IPluginState => {
    const pluginState = value as IPluginState;
    return pluginState.inputs !== undefined && pluginState.outputs !== undefined;
};
                Severity: Major
                Found in src/store/rootReducer.ts and 1 other location - About 1 hr to fix
                src/registry/commonPluginActionDefs.ts on lines 126..129

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status