Sign upLogin

RonaldoSetzer/GAME-Battleship

View on GitHub
Star

Showing 7 of 7 total issues

Function exports has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(config) {

  var configuration = {
    basePath: "",
    frameworks: frameworks,
Severity: Minor
Found in karma.conf.js - About 1 hr to fix

    Function exports has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(options) {
  if (!options) options = { isTest: false };

  var tsconfig = options.isTest ? "tsconfig.test.json" : "tsconfig.json";
    Severity: Minor
    Found in webpack.config.js - About 1 hr to fix

      Function addRandomShipToBattleField has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public static addRandomShipToBattleField(battleField: BattleField, size: number): void {
        let direction = Math.floor(Math.random() * 2) ? "horizontal" : "vertical";
        let maxCols = battleField.grid.maxCols;
        let maxRows = battleField.grid.maxRows;
        if (direction === "horizontal") {
      Severity: Minor
      Found in src/battleship/game/utils/BattleFieldUtils.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function drawGrid has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public drawGrid(grid: Grid): void {
        this.clear();
        this.createBackground(grid.maxCols, grid.maxRows);

        for (let row = 0; row < grid.maxRows; row++) {
      Severity: Minor
      Found in src/battleship/views/components/GridDisplay.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateGrid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public updateGrid(grid): void {
        for (let row = 0; row < grid.maxRows; row++) {
            for (let col = 0; col < grid.maxCols; col++) {
                let display: TileDisplay = this._displays.get(this.getKey(col, row));
                if (grid.getTileId(col, row) === Tile.HITTED) {
      Severity: Minor
      Found in src/battleship/views/components/GridDisplay.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getValidTileList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static getValidTileList(battleField: BattleField): Tile[] {
        let tiles = new Array<Tile>();
        for (let row = 0; row < battleField.grid.maxRows; row++) {
            for (let col = 0; col < battleField.grid.maxCols; col++) {
                if (battleField.grid.getTileId(col, row) !== Tile.HITTED) {
      Severity: Minor
      Found in src/battleship/game/utils/BattleFieldUtils.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      TODO found
      Open

      TODO:
      Severity: Minor
      Found in README.md by fixme
      Severity
      Category
      Status
      Source
      Language