Function parseCrontab has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
public static function parseCrontab($cron, $taskClass)
{
$cronArray = explode(PHP_EOL, $cron);
$tasks = [];
foreach ($cronArray as $cronElement) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parseCrontab has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function parseCrontab($cron, $taskClass)
{
$cronArray = explode(PHP_EOL, $cron);
$tasks = [];
foreach ($cronArray as $cronElement) {Method editTask has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public static function editTask($task, $time, $command, $status = TaskInterface::TASK_STATUS_ACTIVE,
$comment = null)Function parseCommand has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public static function parseCommand($command)
{
if (preg_match('/([@\w\\\\]+)::(\w+)\((.*)\)/', $command, $match)) {
$params = explode(',', $match[3]);
// trim params and strip quotes- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid assigning values to variables in if clauses and the like (line '30', column '14'). Open
public static function editTask($task, $time, $command, $status = TaskInterface::TASK_STATUS_ACTIVE,
$comment = null)
{
if (!$validatedCommand = self::validateCommand($command)) {
return $task;- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid using static access to class '\Cron\CronExpression' in method 'parseCrontab'. Open
CronExpression::factory($matches[2]);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Yii' in method 'parseCrontab'. Open
$task[1] = \Yii::t('cron', 'Comment');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Yii' in method 'parseCrontab'. Open
$task[1] = \Yii::t('cron', 'Saved');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Yii' in method 'parseCrontab'. Open
$task[1] = \Yii::t('cron', 'Not matched');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Yii' in method 'parseCrontab'. Open
$task[1] = \Yii::t('cron', 'Time expression is not valid');- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}