Rossmann-IT/yii2-cron

View on GitHub
src/components/TaskRunner.php

Summary

Maintainability
C
1 day
Test Coverage

Function checkAndRunTasks has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    public static function checkAndRunTasks($tasks)
    {
        $invocationTimestamp = time();
        $invocationDatetime = date('Y-m-d H:i:00');

Severity: Minor
Found in src/components/TaskRunner.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method runTask has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function runTask($task)
    {
        $result = $task->acquireLock();
        if ($result) {
            $run = $task->createTaskRun();
Severity: Major
Found in src/components/TaskRunner.php - About 2 hrs to fix

    Function runTask has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function runTask($task)
        {
            $result = $task->acquireLock();
            if ($result) {
                $run = $task->createTaskRun();
    Severity: Minor
    Found in src/components/TaskRunner.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method checkAndRunTasks has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function checkAndRunTasks($tasks)
        {
            $invocationTimestamp = time();
            $invocationDatetime = date('Y-m-d H:i:00');
    
    
    Severity: Minor
    Found in src/components/TaskRunner.php - About 1 hr to fix

      The method runTask() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
      Open

          public static function runTask($task)
          {
              $result = $task->acquireLock();
              if ($result) {
                  $run = $task->createTaskRun();
      Severity: Minor
      Found in src/components/TaskRunner.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Avoid using static access to class 'rossmann\cron\components\TaskManager' in method 'parseAndRunCommand'.
      Open

                  list($class, $method, $args) = TaskManager::parseCommand($command);
      Severity: Minor
      Found in src/components/TaskRunner.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class 'rossmann\cron\components\TaskLoader' in method 'parseAndRunCommand'.
      Open

                      TaskLoader::loadController($class);
      Severity: Minor
      Found in src/components/TaskRunner.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Yii' in method 'log'.
      Open

              \Yii::$level($message);
      Severity: Minor
      Found in src/components/TaskRunner.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\rossmann\cron\models\TaskRun' in method 'runTask'.
      Open

                  $lastRun = TaskRun::getLast($task->getId());
      Severity: Minor
      Found in src/components/TaskRunner.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Cron\CronExpression' in method 'getRunDates'.
      Open

                  $cron  = CronExpression::factory($time);
      Severity: Minor
      Found in src/components/TaskRunner.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Cron\CronExpression' in method 'checkAndRunTasks'.
      Open

                  $cron = CronExpression::factory($task->getTime());
      Severity: Minor
      Found in src/components/TaskRunner.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\rossmann\cron\models\TaskRun' in method 'checkAndRunTasks'.
      Open

                  $lastRun = TaskRun::getLast($task->getId());
      Severity: Minor
      Found in src/components/TaskRunner.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      There are no issues that match your filters.

      Category
      Status