Roverr/rtsp-stream

View on GitHub

Showing 6 of 6 total issues

Method Controller.StartStreamHandler has 65 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Controller) StartStreamHandler(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    if !c.isAuthenticated(r, "start") {
        w.WriteHeader(http.StatusForbidden)
        return
    }
Severity: Minor
Found in core/controller.go - About 1 hr to fix

    Method Controller.isAuthenticated has 11 return statements (exceeds 4 allowed).
    Open

    func (c *Controller) isAuthenticated(r *http.Request, endpoint string) bool {
        if !c.spec.JWTEnabled {
            return true
        }
        token, claims := c.jwt.Validate(r.Header.Get("Authorization"))
    Severity: Major
    Found in core/controller.go - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              streamer.ProcessLoggingOpts{
                  Enabled:    c.spec.ProcessLogging.Enabled,
                  Compress:   c.spec.ProcessLogging.Compress,
                  Directory:  c.spec.ProcessLogging.Directory,
                  MaxAge:     c.spec.ProcessLogging.MaxAge,
      Severity: Minor
      Found in core/controller.go and 1 other location - About 40 mins to fix
      core/controller.go on lines 425..432

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method Controller.StartStreamHandler has 6 return statements (exceeds 4 allowed).
      Open

      func (c *Controller) StartStreamHandler(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
          if !c.isAuthenticated(r, "start") {
              w.WriteHeader(http.StatusForbidden)
              return
          }
      Severity: Major
      Found in core/controller.go - About 40 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                streamer.ProcessLoggingOpts{
                    Enabled:    c.spec.ProcessLogging.Enabled,
                    Compress:   c.spec.ProcessLogging.Compress,
                    Directory:  c.spec.ProcessLogging.Directory,
                    MaxAge:     c.spec.ProcessLogging.MaxAge,
        Severity: Minor
        Found in core/controller.go and 1 other location - About 40 mins to fix
        core/controller.go on lines 344..351

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 110.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method Controller.StopStreamHandler has 5 return statements (exceeds 4 allowed).
        Open

        func (c *Controller) StopStreamHandler(w http.ResponseWriter, r *http.Request, p httprouter.Params) {
            if !c.isAuthenticated(r, "stop") {
                w.WriteHeader(http.StatusForbidden)
                return
            }
        Severity: Major
        Found in core/controller.go - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language