Showing 16 of 16 total issues
File Google.php
has 443 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace RubtsovAV\Serps\Client;
use RubtsovAV\Serps\Core\Client\Client;
Similar blocks of code found in 2 locations. Consider refactoring. Open
protected function createDumpCaptchaConfirmResponse(SearchEngineResponse $response)
{
$this->logger->debug('Client\Google->createDumpCaptchaConfirmResponse');
$dumpString = '';
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 151.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
protected function createDumpInvalidResponse(SearchEngineResponse $response)
{
$this->logger->debug('Client\Google->createDumpInvalidResponse');
$dumpString = '';
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 151.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function sendQuery
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
protected function sendQuery()
{
$this->logger->debug('Client\Google->sendQuery');
$proxy = $this->getProxy();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Google
has 22 functions (exceeds 20 allowed). Consider refactoring. Open
class Google extends Client
{
protected $httpClient;
protected $googleClient;
protected $googleUrl;
Method sendQuery
has 58 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function sendQuery()
{
$this->logger->debug('Client\Google->sendQuery');
$proxy = $this->getProxy();
Method setGeoLocationCookie
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function setGeoLocationCookie()
{
$this->logger->debug('Client\Google->setGeoLocationCookie');
$region = $this->query->getSearchRegion();
Method executeQuery
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function executeQuery()
{
$this->logger->debug('Client\Google->executeQuery');
$this->setGeoLocationCookie();
Method getCaptchaConfirmParams
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function getCaptchaConfirmParams(GoogleCaptcha $captcha, $captchaAnswer)
{
$xpath = $captcha->getErrorPage()->getXpath();
$form = $xpath->query('//body/div/form')->item(0);
Function getItemsFromSerp
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function getItemsFromSerp(GoogleSerp $serp)
{
try {
$serpItems = $serp->getNaturalResults();
} catch (InvalidDOMException $ex) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getItemsFromSerp
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function getItemsFromSerp(GoogleSerp $serp)
{
try {
$serpItems = $serp->getNaturalResults();
} catch (InvalidDOMException $ex) {
Function longExecuteQueryBy
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function longExecuteQueryBy(Client $client, Query $query)
{
$queryExecutor = $this->createPreparedQueryExecutor($client, $query);
while (true) {
try {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getCaptchaConfirmParams
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function getCaptchaConfirmParams(GoogleCaptcha $captcha, $captchaAnswer)
{
$xpath = $captcha->getErrorPage()->getXpath();
$form = $xpath->query('//body/div/form')->item(0);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function createGuise
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function createGuise()
{
$cookieStorage = new ArrayCookieJar();
$proxy = null;
$httpHeaders = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function executeQuery
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function executeQuery()
{
$this->logger->debug('Client\Google->executeQuery');
$this->setGeoLocationCookie();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function addItem
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function addItem(ItemPosition $item)
{
$this->logger->debug('QueryResult->addItem');
if ($this->isComplete()) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"