Sign upLogin

Runnable/docker-mock

View on GitHub
Star

Showing 15 of 15 total issues

File index.js has 308 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'

var app = require('express')()
var BaseStore = require('./models/base-store')
var bodyParser = require('body-parser')
Severity: Minor
Found in lib/index.js - About 3 hrs to fix

    Function build has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ImageStore.prototype.build = function (req) {
  var self = this
  return new Promise(function (resolve, reject) {
    var foundDockerFile = false
    // TODO query.t is required
    Severity: Major
    Found in lib/models/image-store.js - About 2 hrs to fix

      Function Container has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function Container (opts) {
  if (!opts) { opts = {} }
  var Id = utils.randomId()
  var data = {
    Id: Id,
      Severity: Major
      Found in lib/models/container.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          containers
    .findOneByIdOrName(req.params.id)
    .then(function (container) {
      return container.start()
    })
        Severity: Major
        Found in lib/index.js and 1 other location - About 1 hr to fix
        lib/index.js on lines 128..136

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          containers
    .findOneByIdOrName(req.params.id)
    .then(function (container) {
      return container.stop()
    })
        Severity: Major
        Found in lib/index.js and 1 other location - About 1 hr to fix
        lib/index.js on lines 116..124

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function create has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        ImageStore.prototype.create = function (req, res, callback) {
  // don't promisify this, it's actually middleware atm.
  var id = utils.randomId()
  var from = req.query.fromImage
  var emitter = duplexEmitter(res)
        Severity: Minor
        Found in lib/models/image-store.js - About 1 hr to fix

          Function createContainer has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          ContainerStore.prototype.createContainer = function (body) {
  return Promise.resolve()
    .bind(this)
    .then(function () {
      if (body.name) {
          Severity: Minor
          Found in lib/models/container-store.js - About 1 hr to fix

            Function findOneByName has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            ImageStore.prototype.findOneByName = function (name) {
  return Promise.resolve()
    .bind(this)
    .then(function () {
      var image = this._store[name]
            Severity: Minor
            Found in lib/models/image-store.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function start has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Container.prototype.start = function (wasRestart) {
  return Promise.resolve()
    .bind(this)
    .then(function () {
      if (this.State.Running) {
            Severity: Minor
            Found in lib/models/container.js - About 1 hr to fix

              Function stop has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              Container.prototype.stop = function (ignoreStopped, killSignal) {
  var exitCode = (killSignal === 'SIGKILL') ? 1 : 0
  return Promise.resolve()
    .bind(this)
    .then(function () {
              Severity: Minor
              Found in lib/models/container.js - About 1 hr to fix

                Function getEvents has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                  getEvents: function (targetStream) {
    return function (req, res) {
      // do streaming when params are not specified
      // send response immediately when params are there
      if (req.query.since || req.query.until) {
                Severity: Minor
                Found in lib/middleware.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getStats has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                Container.prototype.getStats = function (req, res) {
  // The default value is stream=1
  if (req.query.stream === '0') {
    res.send(sampleStats)
  } else {
                Severity: Minor
                Found in lib/models/container.js - About 1 hr to fix

                  Function _runFilters has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  ContainerStore._runFilters = function (containers, filters) {
  Object.keys(filters).forEach(function (filter) {
    switch (filter) {
      case 'label':
        var key = Object.keys(filters[filter])[0]
                  Severity: Minor
                  Found in lib/models/container-store.js - About 1 hr to fix

                    Function listImages has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                    ImageStore.prototype.listImages = function () {
  return Promise.resolve()
    .bind(this)
    .then(function () {
      return Object.keys(this._store).map(function (id) {
                    Severity: Minor
                    Found in lib/models/image-store.js - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _read has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    StatsStream.prototype._read = function () {
  if (this.container.State.Running) {
    this.push(sampleStats)
  } else {
    this.container.once('event', function (event) {
                    Severity: Minor
                    Found in lib/models/container.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language