Runnable/docker-mock

View on GitHub
lib/models/image-store.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function build has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ImageStore.prototype.build = function (req) {
  var self = this
  return new Promise(function (resolve, reject) {
    var foundDockerFile = false
    // TODO query.t is required
Severity: Major
Found in lib/models/image-store.js - About 2 hrs to fix

    Function create has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ImageStore.prototype.create = function (req, res, callback) {
      // don't promisify this, it's actually middleware atm.
      var id = utils.randomId()
      var from = req.query.fromImage
      var emitter = duplexEmitter(res)
    Severity: Minor
    Found in lib/models/image-store.js - About 1 hr to fix

      Function findOneByName has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      ImageStore.prototype.findOneByName = function (name) {
        return Promise.resolve()
          .bind(this)
          .then(function () {
            var image = this._store[name]
      Severity: Minor
      Found in lib/models/image-store.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function listImages has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      ImageStore.prototype.listImages = function () {
        return Promise.resolve()
          .bind(this)
          .then(function () {
            return Object.keys(this._store).map(function (id) {
      Severity: Minor
      Found in lib/models/image-store.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status