Sign upLogin

Runnable/ponos

View on GitHub
Star

Showing 21 of 21 total issues

File rabbitmq.js has 496 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* @flow */
/* global Bluebird$Promise RabbitMQChannel RabbitMQConfirmChannel RabbitMQConnection SubscribeObject RabbitMQOptions QueueObject */
'use strict'

const amqplib = require('amqplib')
Severity: Minor
Found in src/rabbitmq.js - About 7 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      setAllEvents (map: Object): Server {
    if (!isObject(map)) {
      throw new Error('ponos.server: setAllEvents must be called with an object')
    }
    Object.keys(map).forEach((key) => {
    Severity: Major
    Found in src/server.js and 1 other location - About 7 hrs to fix
    src/server.js on lines 202..220

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 188.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      setAllTasks (map: Object): Server {
    if (!isObject(map)) {
      throw new Error('ponos.server: setAllTasks must be called with an object')
    }
    Object.keys(map).forEach((key) => {
    Severity: Major
    Found in src/server.js and 1 other location - About 7 hrs to fix
    src/server.js on lines 232..250

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 188.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      setTask (queueName: string, task: Function, opts?: Object): Server {
    this.log.trace({
      method: 'setTask',
      queueName,
      opts
    Severity: Major
    Found in src/server.js and 1 other location - About 4 hrs to fix
    src/server.js on lines 286..302

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 127.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      setEvent (exchangeName: string, task: Function, opts?: Object): Server {
    this.log.trace({
      method: 'setEvent',
      exchangeName,
      opts
    Severity: Major
    Found in src/server.js and 1 other location - About 4 hrs to fix
    src/server.js on lines 260..276

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 127.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    RabbitMQ has 27 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class RabbitMQ {
  static AMQPLIB_QUEUE_DEFAULTS: Object;
  static AMQPLIB_EXCHANGE_DEFAULTS: Object;

  channel: RabbitMQChannel;
    Severity: Minor
    Found in src/rabbitmq.js - About 3 hrs to fix

      File server.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* @flow */
/* global Bluebird$Promise Logger */
'use strict'
const assign = require('101/assign')
const clone = require('101/clone')
      Severity: Minor
      Found in src/server.js - About 2 hrs to fix

        Function connect has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          connect (): Bluebird$Promise<void> {
    if (this._isPartlyConnected() || this._isConnected()) {
      return Promise.reject(new Error('cannot call connect twice'))
    }
    let authString = ''
        Severity: Major
        Found in src/rabbitmq.js - About 2 hrs to fix

          Function constructor has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            constructor (opts: Object) {
    this._opts = assign({}, opts)
    this.log = this._opts.log || logger.child({ module: 'ponos:server' })
    this._workerOptions = {}
    this._workQueues = {}
          Severity: Minor
          Found in src/server.js - About 1 hr to fix

            Function _subscribeToExchange has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              _subscribeToExchange (opts: SubscribeObject): Bluebird$Promise<void> {
    const log = this.log.child({
      method: '_subscribeToExchange',
      opts: opts
    })
            Severity: Minor
            Found in src/rabbitmq.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                publishToExchange (
    exchange: string,
    routingKey: string,
    content: Object
  ): Bluebird$Promise<void> {
              Severity: Major
              Found in src/rabbitmq.js and 1 other location - About 1 hr to fix
              src/rabbitmq.js on lines 223..232

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 66.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                publishToQueue (queue: string, content: Object): Bluebird$Promise<void> {
    return Promise.try(() => {
      this.log.warn({
        method: 'publishToQueue',
        queue
              Severity: Major
              Found in src/rabbitmq.js and 1 other location - About 1 hr to fix
              src/rabbitmq.js on lines 248..261

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 66.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function consume has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                consume (): Bluebird$Promise<void> {
    const log = this.log.child({ method: 'consume' })
    log.info('starting to consume')
    if (!this._isConnected()) {
      return Promise.reject(new Error('you must .connect() before consuming'))
              Severity: Minor
              Found in src/rabbitmq.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        return Promise.resolve(this.connection.createConfirmChannel())
          .catch((err) => {
            this.log.fatal({ err: err }, 'errored creating confirm channel')
            throw err
          })
                Severity: Major
                Found in src/rabbitmq.js and 1 other location - About 1 hr to fix
                src/rabbitmq.js on lines 156..160

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        return Promise.resolve(this.connection.createChannel())
          .catch((err) => {
            this.log.fatal({ err: err }, 'an error occured creating channel')
            throw err
          })
                Severity: Major
                Found in src/rabbitmq.js and 1 other location - About 1 hr to fix
                src/rabbitmq.js on lines 176..180

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function limit has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  limit (queueName: string, opts: Object): Bluebird$Promise<void> {
    const log = this.log.child({
      queueName: queueName,
      opts: pick(opts, ['msTimeout', 'maxNumRetries', 'durationMs', 'maxOperations'])
    })
                Severity: Minor
                Found in src/rate-limiters/redis.js - About 1 hr to fix

                  Function run has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    run (): Promise<void> {
    this._incMonitor('ponos')
    const timer = this._createTimer()
    this.log = this.log.child({
      method: 'run',
                  Severity: Minor
                  Found in src/worker.js - About 1 hr to fix

                    Function constructor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                      constructor (opts: Object) {
    this._opts = assign({}, opts)
    this.log = this._opts.log || logger.child({ module: 'ponos:server' })
    this._workerOptions = {}
    this._workQueues = {}
                    Severity: Minor
                    Found in src/server.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (opts.type === 'topic' && opts.routingKey) {
      queueName = `${queueName}.${opts.routingKey}`
    }
                    Severity: Minor
                    Found in src/rabbitmq.js and 1 other location - About 35 mins to fix
                    src/rabbitmq.js on lines 650..652

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (opts.type === 'topic' && opts.routingKey) {
      subscribedKey = `${subscribedKey}:::${opts.routingKey}`
    }
                    Severity: Minor
                    Found in src/rabbitmq.js and 1 other location - About 35 mins to fix
                    src/rabbitmq.js on lines 660..662

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language