Runnable/ponos

View on GitHub

Showing 10 of 21 total issues

File rabbitmq.js has 496 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* @flow */
/* global Bluebird$Promise RabbitMQChannel RabbitMQConfirmChannel RabbitMQConnection SubscribeObject RabbitMQOptions QueueObject */
'use strict'

const amqplib = require('amqplib')
Severity: Minor
Found in src/rabbitmq.js - About 7 hrs to fix

    RabbitMQ has 27 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class RabbitMQ {
      static AMQPLIB_QUEUE_DEFAULTS: Object;
      static AMQPLIB_EXCHANGE_DEFAULTS: Object;
    
      channel: RabbitMQChannel;
    Severity: Minor
    Found in src/rabbitmq.js - About 3 hrs to fix

      File server.js has 273 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* @flow */
      /* global Bluebird$Promise Logger */
      'use strict'
      const assign = require('101/assign')
      const clone = require('101/clone')
      Severity: Minor
      Found in src/server.js - About 2 hrs to fix

        Function connect has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          connect (): Bluebird$Promise<void> {
            if (this._isPartlyConnected() || this._isConnected()) {
              return Promise.reject(new Error('cannot call connect twice'))
            }
            let authString = ''
        Severity: Major
        Found in src/rabbitmq.js - About 2 hrs to fix

          Function constructor has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            constructor (opts: Object) {
              this._opts = assign({}, opts)
              this.log = this._opts.log || logger.child({ module: 'ponos:server' })
              this._workerOptions = {}
              this._workQueues = {}
          Severity: Minor
          Found in src/server.js - About 1 hr to fix

            Function _subscribeToExchange has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              _subscribeToExchange (opts: SubscribeObject): Bluebird$Promise<void> {
                const log = this.log.child({
                  method: '_subscribeToExchange',
                  opts: opts
                })
            Severity: Minor
            Found in src/rabbitmq.js - About 1 hr to fix

              Function consume has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                consume (): Bluebird$Promise<void> {
                  const log = this.log.child({ method: 'consume' })
                  log.info('starting to consume')
                  if (!this._isConnected()) {
                    return Promise.reject(new Error('you must .connect() before consuming'))
              Severity: Minor
              Found in src/rabbitmq.js - About 1 hr to fix

                Function limit has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  limit (queueName: string, opts: Object): Bluebird$Promise<void> {
                    const log = this.log.child({
                      queueName: queueName,
                      opts: pick(opts, ['msTimeout', 'maxNumRetries', 'durationMs', 'maxOperations'])
                    })
                Severity: Minor
                Found in src/rate-limiters/redis.js - About 1 hr to fix

                  Function run has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    run (): Promise<void> {
                      this._incMonitor('ponos')
                      const timer = this._createTimer()
                      this.log = this.log.child({
                        method: 'run',
                  Severity: Minor
                  Found in src/worker.js - About 1 hr to fix

                    Function constructor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                      constructor (opts: Object) {
                        this._opts = assign({}, opts)
                        this.log = this._opts.log || logger.child({ module: 'ponos:server' })
                        this._workerOptions = {}
                        this._workQueues = {}
                    Severity: Minor
                    Found in src/server.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language