SAREhub/PHP_Client

View on GitHub
src/SAREhub/Client/Processor/Pipeline.php

Summary

Maintainability
A
55 mins
Test Coverage

Function process has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function process(Exchange $exchange)
    {
        $currentExchange = $exchange;
        $orginalMessage = $currentExchange->getIn();

Severity: Minor
Found in src/SAREhub/Client/Processor/Pipeline.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $currentExchange = $this->createNextExchange($currentExchange);
            }

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The closing brace for the class must go on the next line after the body
Open

}

Expected 1 newline at end of file; 0 found
Open

}

There are no issues that match your filters.

Category
Status