src/SAREhub/Client/Util/StreamHelper.php
The method select uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
return stream_select($read, $write, $except, $sec, $usec);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused local variables such as '$except'. Open
Open
return stream_select($read, $write, $except, $sec, $usec);- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$expect'. Open
Open
$expect = null;- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
There must be one blank line after the namespace declaration Open
Open
namespace SAREhub\Client\Util;- Exclude checks
Expected 1 newline at end of file; 0 found Open
Open
}- Exclude checks