Sign upLogin

SAREhub/PHP_Commons

View on GitHub
Star

Showing 139 of 139 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

use SAREhub\Commons\Misc\Dsn;
use SAREhub\Commons\Zmq\PublishSubscribe\Subscriber;
Severity: Major
Found in examples/zmq/publish_subscribe/3/subscriber.php and 1 other location - About 4 hrs to fix
examples/zmq/publish_subscribe/1/subscriber.php on lines 1..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 179.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

use SAREhub\Commons\Misc\Dsn;
use SAREhub\Commons\Zmq\PublishSubscribe\Subscriber;
Severity: Major
Found in examples/zmq/publish_subscribe/1/subscriber.php and 1 other location - About 4 hrs to fix
examples/zmq/publish_subscribe/3/subscriber.php on lines 1..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 179.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 5 and the first side effect is on line 3.
Open

<?php
Severity: Minor
Found in examples/ExampleCommons.php by phpcodesniffer

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct(callable $callback, array $expectedErrorClasses = [], int $maxRetries = 3, float $initialWait = 1.0, int $exponent = 2)
Severity: Minor
Found in src/SAREhub/Commons/Misc/RetryFunctionWrapper.php - About 35 mins to fix

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

        }
    Severity: Minor
    Found in src/SAREhub/Commons/Zmq/PublishSubscribe/SubscriptionTopic.php by phpcodesniffer

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

        }
    Severity: Minor
    Found in src/SAREhub/Commons/Service/ServiceSupport.php by phpcodesniffer

    Expected 1 blank line at end of file; 2 found
    Open

    };
    Severity: Minor
    Found in examples/process/pcntl_signals/1/example.php by phpcodesniffer

    There must be one blank line after the namespace declaration
    Open

    namespace SAREhub\Commons\Config;
    Severity: Minor
    Found in src/SAREhub/Commons/Config/ConfigLoaderException.php by phpcodesniffer

    There must be one blank line after the namespace declaration
    Open

    namespace SAREhub\Commons\Misc;
    Severity: Minor
    Found in src/SAREhub/Commons/Misc/EnvironmentHelper.php by phpcodesniffer

    There must be one blank line after the namespace declaration
    Open

    namespace SAREhub\Commons\Misc;
    Severity: Minor
    Found in src/SAREhub/Commons/Misc/PackFormat.php by phpcodesniffer

    The closing brace for the class must go on the next line after the body
    Open

    }
    Severity: Minor
    Found in src/SAREhub/Commons/Misc/TimeProvider.php by phpcodesniffer

    There must be one blank line after the namespace declaration
    Open

    namespace SAREhub\Commons\Time;
    Severity: Minor
    Found in src/SAREhub/Commons/Time/CronTask.php by phpcodesniffer

    There must be one blank line after the namespace declaration
    Open

    namespace SAREhub\Commons\Logger;
    Severity: Minor
    Found in src/SAREhub/Commons/Logger/BasicLoggingDefinitions.php by phpcodesniffer

    There must be one blank line after the namespace declaration
    Open

    namespace SAREhub\Commons\Service;
    Severity: Minor
    Found in src/SAREhub/Commons/Service/ServiceManager.php by phpcodesniffer

    The closing brace for the class must go on the next line after the body
    Open

    }
    Severity: Minor
    Found in src/SAREhub/Commons/Time/StaticTimeProvider.php by phpcodesniffer

    The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line
    Open

        {
    Severity: Minor
    Found in src/SAREhub/Commons/Logger/StreamLoggerFactoryProvider.php by phpcodesniffer

    There must be one blank line after the namespace declaration
    Open

    namespace SAREhub\Commons\Logger;
    Severity: Minor
    Found in src/SAREhub/Commons/Logger/StreamLoggerFactoryProvider.php by phpcodesniffer

    There must be one blank line after the namespace declaration
    Open

    namespace SAREhub\Commons\Secret;
    Severity: Minor
    Found in src/SAREhub/Commons/Secret/SecretValueNotFoundException.php by phpcodesniffer

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

        }
    Severity: Minor
    Found in src/SAREhub/Commons/Service/ServiceSupport.php by phpcodesniffer

    There must be one blank line after the namespace declaration
    Open

    namespace SAREhub\Commons\Task;
    Severity: Minor
    Found in src/SAREhub/Commons/Task/Task.php by phpcodesniffer
    Severity
    Category
    Status
    Source
    Language