Sign upLogin

SDP-GeoHunt/geo-hunt

View on GitHub
Star

Showing 168 of 168 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    /**
     * Get all claims of a specific user [user]. If one of his claim is not within the database
     * due to some internal issues then throws [ClaimNotFoundException]. Notice that this function
     * does not check whether the provided user exists or not !!
     */
Severity: Minor
Found in app/src/main/java/com/github/geohunt/app/data/repository/ClaimRepositoryInterface.kt and 1 other location - About 30 mins to fix
app/src/main/java/com/github/geohunt/app/data/repository/ClaimRepositoryInterface.kt on lines 13..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    /**
     * Retrieve a list of all claims id for a specific user, useful when lazy loading
     */
    suspend fun getClaimId(user: User): List<String> {
        return getClaimId(user.id)
Severity: Minor
Found in app/src/main/java/com/github/geohunt/app/data/repository/ClaimRepositoryInterface.kt and 1 other location - About 30 mins to fix
app/src/main/java/com/github/geohunt/app/data/repository/ClaimRepositoryInterface.kt on lines 32..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    suspend fun uploadProfilePicture(picture: LocalPicture, id: String) = uploadImage(picture, ImageType.PROFILE_PICTURE, id)
Severity: Minor
Found in app/src/main/java/com/github/geohunt/app/data/repository/ImageRepository.kt and 1 other location - About 30 mins to fix
app/src/main/java/com/github/geohunt/app/data/repository/ImageRepository.kt on lines 94..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    suspend fun uploadClaimPhoto(photo: LocalPicture, id: String) =
        uploadImage(photo, ImageType.CLAIM_PHOTO, id)
Severity: Minor
Found in app/src/main/java/com/github/geohunt/app/data/repository/ImageRepository.kt and 1 other location - About 30 mins to fix
app/src/main/java/com/github/geohunt/app/data/repository/ImageRepository.kt on lines 85..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            "followList/${currentUser.id}/${user.id}" to true.takeIf { follow },
Severity: Minor
Found in app/src/main/java/com/github/geohunt/app/data/repository/FollowRepository.kt and 1 other location - About 30 mins to fix
app/src/main/java/com/github/geohunt/app/data/repository/FollowRepository.kt on lines 83..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            "followers/${user.id}/${currentUser.id}" to true.takeIf { follow },
Severity: Minor
Found in app/src/main/java/com/github/geohunt/app/data/repository/FollowRepository.kt and 1 other location - About 30 mins to fix
app/src/main/java/com/github/geohunt/app/data/repository/FollowRepository.kt on lines 82..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method ShowChallengeDescription has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

/**
 * @brief Show a card containing the challenge description that is expandable
 *
 * @param challengeDescription the description of the challenge to be displayed
 */
Severity: Minor
Found in app/src/main/java/com/github/geohunt/app/ui/components/challenge/ChallengeView.kt - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method EditProfileContent has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

@Composable
fun EditProfileContent(
    user: User,
    eu: EditedUser,
    onDisplayNameChange: (String) -> Unit,
Severity: Minor
Found in app/src/main/java/com/github/geohunt/app/ui/components/profile/edit/EditProfileContent.kt - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language