Sign upLogin

SDPCoachMe/SDP-2023

View on GitHub
Star
app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt

Summary

Maintainability
F
3 days
Test Coverage
A
94%

File CachingStore.kt has 523 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.github.sdpcoachme.database

import android.content.Context
import android.net.ConnectivityManager
import android.net.NetworkCapabilities
Severity: Major
Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt - About 1 day to fix

    Method getSchedule has a Cognitive Complexity of 65 (exceeds 20 allowed). Consider refactoring.
    Open

        /**
     * Gets the schedule for the current user
     *
     * @param currentWeekMonday the monday of the current week
     * @return a completable future that completes when the schedule has been retrieved (containing the newly cached schedule)
    Severity: Minor
    Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class CachingStore has 41 methods (exceeds 20 allowed). Consider refactoring.
    Open

    /**
 * A caching database that wraps another database
 */
class CachingStore(private val wrappedDatabase: Database,
                   private val dataStore: DataStore<Preferences>,
    Severity: Minor
    Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt - About 5 hrs to fix

      Method getSchedule has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          /**
     * Gets the schedule for the current user
     *
     * @param currentWeekMonday the monday of the current week
     * @return a completable future that completes when the schedule has been retrieved (containing the newly cached schedule)
      Severity: Minor
      Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                                    val events = schedule.events.filter {
                                val start = LocalDateTime.parse(it.start).toLocalDate()
                                val end = LocalDateTime.parse(it.end).toLocalDate()
                                start >= minCachedMonday && end <= maxCachedMonday
                            }
        Severity: Major
        Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt and 1 other location - About 1 hr to fix
        app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt on lines 480..484

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                                    if (it != Event()) {
                                val start = LocalDateTime.parse(it.start).toLocalDate()
                                val end = LocalDateTime.parse(it.end).toLocalDate()
                                start >= minCachedMonday && end <= maxCachedMonday
                            } else {
        Severity: Major
        Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt and 1 other location - About 1 hr to fix
        app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt on lines 507..511

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    cachedSchedule = cachedSchedule.copy(
                events = cachedSchedule.events + EventOps.groupEventsToEvents(listOf(groupEvent)),
                groupEvents = cachedSchedule.groupEvents + groupEventId
            )
        Severity: Minor
        Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt and 1 other location - About 55 mins to fix
        app/src/main/java/com/github/sdpcoachme/database/FireDatabase.kt on lines 69..72

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 84.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

                return wrappedDatabase.getFCMToken(email).thenApply {
            it.also {
                cachedTokens[email] = it
                storeLocalData()
            }
        Severity: Minor
        Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt and 1 other location - About 45 mins to fix
        app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt on lines 575..580

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

                return wrappedDatabase.getChat(chatId).thenApply {
            it.also {
                chats[chatId] = it
                storeLocalData()
            }
        Severity: Minor
        Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt and 1 other location - About 45 mins to fix
        app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt on lines 765..770

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    is WeatherForecast -> {
                val forecast = gson.fromJson<WeatherForecast>(jsonString, type)
                weatherForecast = forecast
            }
        Severity: Minor
        Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt and 1 other location - About 35 mins to fix
        app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt on lines 144..147

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    is Schedule -> {
                val schedule = gson.fromJson<Schedule>(jsonString, type)
                cachedSchedule = schedule
            }
        Severity: Minor
        Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt and 1 other location - About 35 mins to fix
        app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt on lines 148..151

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            schedule.copy(events = events + transformedGroupEvents)
                        .also {   // Update the cache
                            cachedSchedule = it
                            storeLocalData()
                        }
        Severity: Minor
        Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt and 1 other location - About 35 mins to fix
        app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt on lines 516..519

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                                    schedule.copy(events = events + transformedGroupEvents).also {
                                cachedSchedule = it  // Update the cache
                                storeLocalData()
                            }
        Severity: Minor
        Found in app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt and 1 other location - About 35 mins to fix
        app/src/main/java/com/github/sdpcoachme/database/CachingStore.kt on lines 491..495

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status