Sign upLogin

SDPCoachMe/SDP-2023

View on GitHub
Star
app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt

Summary

Maintainability
D
2 days
Test Coverage
A
90%

Method EditTextLayout has a Cognitive Complexity of 57 (exceeds 20 allowed). Consider refactoring.
Open

/**
 * The layout for the EditTextActivity.
 *
 * @param initialValue The initial value of the text field.
 * @param onCancel The callback to be called when the user cancels the operation.
Severity: Minor
Found in app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method EditTextLayout has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

/**
 * The layout for the EditTextActivity.
 *
 * @param initialValue The initial value of the text field.
 * @param onCancel The callback to be called when the user cancels the operation.
Severity: Major
Found in app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt - About 2 hrs to fix

    Method onCreate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        val initialValue = intent.getStringExtra(INITIAL_VALUE_KEY) ?: ""
        val title = intent.getStringExtra(TITLE_KEY) ?: DEFAULT_TITLE
    Severity: Minor
    Found in app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt - About 1 hr to fix

      Method getHandler has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              /**
         * Creates a handler that can be used to launch this activity. This method should be called
         * from the onCreate method of the caller activity. The returned handler can be called from
         * anywhere in the caller activity, and takes an Intent as a parameter. The Intent should be
         * created using the getIntent method of this class.
      Severity: Minor
      Found in app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt - About 1 hr to fix

        Method EditTextLayout has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            initialValue: String,
    onCancel: () -> Unit,
    onSubmit: (String) -> Unit,
    title: String,
    label: String?,
        Severity: Minor
        Found in app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt - About 45 mins to fix

          Method getIntent has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                      context: Context,
            title: String? = null,
            placeholder: String? = null,
            label: String? = null,
            initialValue: String? = null
          Severity: Minor
          Found in app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    /**
         * Creates a handler that can be used to launch this activity. This method should be called
         * from the onCreate method of the caller activity. The returned handler can be called from
         * anywhere in the caller activity, and takes an Intent as a parameter. The Intent should be
         * created using the getIntent method of this class.
            Severity: Major
            Found in app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt and 1 other location - About 4 hrs to fix
            app/src/main/java/com/github/sdpcoachme/rating/RatingActivity.kt on lines 54..85

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 325.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                    class EditTextCancelledException(message: String? = null, cause: Throwable? = null) : Exception(message, cause) {
            constructor(cause: Throwable) : this(null, cause)
        }
            Severity: Major
            Found in app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt and 6 other locations - About 1 hr to fix
            app/src/main/java/com/github/sdpcoachme/database/Database.kt on lines 178..181
            app/src/main/java/com/github/sdpcoachme/location/autocomplete/AddressAutocompleteHandler.kt on lines 25..28
            app/src/main/java/com/github/sdpcoachme/location/autocomplete/AddressAutocompleteHandler.kt on lines 29..31
            app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt on lines 149..152
            app/src/main/java/com/github/sdpcoachme/rating/RatingActivity.kt on lines 91..94
            app/src/main/java/com/github/sdpcoachme/rating/RatingActivity.kt on lines 95..97

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                    // Used to handle edit text activity errors or cancelling
        class EditTextFailedException(message: String? = null, cause: Throwable? = null) : Exception(message, cause) {
            constructor(cause: Throwable) : this(null, cause)
        }
            Severity: Major
            Found in app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt and 6 other locations - About 1 hr to fix
            app/src/main/java/com/github/sdpcoachme/database/Database.kt on lines 178..181
            app/src/main/java/com/github/sdpcoachme/location/autocomplete/AddressAutocompleteHandler.kt on lines 25..28
            app/src/main/java/com/github/sdpcoachme/location/autocomplete/AddressAutocompleteHandler.kt on lines 29..31
            app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt on lines 153..155
            app/src/main/java/com/github/sdpcoachme/rating/RatingActivity.kt on lines 91..94
            app/src/main/java/com/github/sdpcoachme/rating/RatingActivity.kt on lines 95..97

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                    onSubmit = {
                            setResult(RESULT_OK, Intent().putExtra(RETURN_VALUE_KEY, it))
                            finish()
                        },
            Severity: Minor
            Found in app/src/main/java/com/github/sdpcoachme/profile/EditTextActivity.kt and 1 other location - About 30 mins to fix
            app/src/main/java/com/github/sdpcoachme/rating/RatingActivity.kt on lines 112..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status