SDPepe/AppArt

View on GitHub
app/src/main/java/ch/epfl/sdp/appart/utils/DatabaseSync.java

Summary

Maintainability
A
0 mins
Test Coverage
C
76%

Method writeAndComplete has 9 arguments (exceeds 4 allowed). Consider refactoring.
Wontfix

    private static void writeAndComplete(CompletableFuture<Void> result, LocalDatabaseService ldb,
                                 String adId, String cardId, User user, Ad ad,  List<Bitmap> images,
                                 List<CompletableFuture<Bitmap>> panoramasBitmaps, Bitmap pfp) {
Severity: Major
Found in app/src/main/java/ch/epfl/sdp/appart/utils/DatabaseSync.java - About 1 hr to fix

    Method saveCurrentUserToLocalDB has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Invalid

        public static CompletableFuture<Void> saveCurrentUserToLocalDB(Context context,
                                                                       DatabaseService db,
                                                                       LocalDatabaseService ldb,
                                                                       String userId) {
            CompletableFuture<Void> result = new CompletableFuture<>();
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sdp/appart/utils/DatabaseSync.java - About 1 hr to fix

      Method saveFavoriteAd has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Wontfix

          public static CompletableFuture<Void> saveFavoriteAd(Context context,
                                                                 DatabaseService db,
                                                                 LocalDatabaseService ldb,
                                                                 String cardId, String adId,
                                                                 Ad ad, List<Bitmap> images) {
      Severity: Major
      Found in app/src/main/java/ch/epfl/sdp/appart/utils/DatabaseSync.java - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status