SPF-UiO/spbm

View on GitHub

Showing 2,048 of 2,050 total issues

Remove this commented out code.
Open

            # return [f.name for f in self.model._meta.get_fields()]

Programmers should not comment out code as it bloats programs and reduces readability.

Unused code should be deleted and can be retrieved from source control history if required.

See

  • MISRA C:2004, 2.4 - Sections of code should not be "commented out".
  • MISRA C++:2008, 2-7-2 - Sections of code shall not be "commented out" using C-style comments.
  • MISRA C++:2008, 2-7-3 - Sections of code should not be "commented out" using C++ comments.
  • MISRA C:2012, Dir. 4.4 - Sections of code should not be "commented out"

Take the required action to fix the issue indicated by this "FIXME" comment.
Open

        # FIXME: Creates an overhead of two extra queries per viewing :(

FIXME tags are commonly used to mark places where a bug is suspected, but which the developer wants to deal with later.

Sometimes the developer will not have the time or will simply forget to get back to that tag.

This rule is meant to track those tags and to ensure that they do not go unnoticed.

Noncompliant Code Example

def divide(numerator, denominator):
  return numerator / denominator              # FIXME denominator value might be 0

See

TODO found
Open

# TODO: Execute the default Compose
Severity: Minor
Found in scripts/run_production.sh by fixme

TODO found
Open

    # no idea how to test this properly atm, this is a TODO for later
Severity: Minor
Found in setup.cfg by fixme

TODO found
Open

# TODO Generalize? Import? Something?
Severity: Minor
Found in spbm/apps/society/views/invoicing.py by fixme

TODO found
Open

    # TODO: Create migration from processed to purely invoice, alt. from field to property method.
Severity: Minor
Found in spbm/apps/society/models.py by fixme

TODO found
Open

# TODO: Create intermediate class to decouple current wage system from wage reporting
Severity: Minor
Found in spbm/apps/society/urls.py by fixme

TODO found
Open

    # TODO: Create another Manager, or tweak the query to annotate the cost right here and now.
Severity: Minor
Found in spbm/apps/society/views/events.py by fixme
Severity
Category
Status
Source
Language