Sign upLogin

SPF-UiO/spbm

View on GitHub
Star
spbm/apps/norlonn/views.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function generate_report has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def generate_report(request):
    if request.method != "POST":
        return redirect(index)

    errors = []
Severity: Minor
Found in spbm/apps/norlonn/views.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function index has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def index(request):
    reports = NorlonnReport.objects.all().order_by('-date')
    errors = []

    queryset = Shift.objects.select_related().prefetch_related('event__invoice').filter(norlonn_report__isnull=True,
Severity: Minor
Found in spbm/apps/norlonn/views.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_report has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def get_report(request, date):
    nr = get_object_or_404(NorlonnReport, date=date)
    linjer = []
    personshift = {}
Severity: Minor
Found in spbm/apps/norlonn/views.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return render(request, 'norlonn/report.jinja', {'errors': errors, 'success': succ})
Severity: Major
Found in spbm/apps/norlonn/views.py - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status