Sign upLogin

SPF-UiO/spbm

View on GitHub
Star
spbm/apps/society/views/invoicing.py

Summary

Maintainability
A
1 hr
Test Coverage

Function close_period has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def close_period(self, request):
        """
        Closes the current invoicing period.

        Note that the period cannot be closed twice on the same day, *unless* a new invoice for a previously not
Severity: Minor
Found in spbm/apps/society/views/invoicing.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_context_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def get_context_data(self, **kwargs):
        today = datetime.date.today()

        last_invoice = Invoice.objects.last()
        if last_invoice is None:
Severity: Minor
Found in spbm/apps/society/views/invoicing.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

                # TODO Filter and see if we can close or not, rather than catching an IntegrityError
Severity: Minor
Found in spbm/apps/society/views/invoicing.py by fixme

TODO found
Open

# TODO Generalize? Import? Something?
Severity: Minor
Found in spbm/apps/society/views/invoicing.py by fixme

There are no issues that match your filters.

Category
Status