SU-SWS/caw_profile

View on GitHub

Showing 310 of 395 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  newParentItem(item, depth, parent) {
    var opts = Object.assign(this.options, {
      itemExpandedClass: this.options.itemExpandedClass,
      depth: depth
    });
themes/stanford_basic/src/js/components/secondary-nav/buttons/SecondaryNavButtons.js on lines 63..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 86.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function fetch has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  fetch() {
    try {
      switch (this.what) {
        case 'first':
          return this.item.parentNode.firstElementChild.firstChild;
Severity: Major
Found in themes/stanford_basic/src/js/components/nav/ElementFetcher.js - About 2 hrs to fix

    Function attach has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      attach(context, settings) {
        (function ($, once) {
          // Validate there is a skip link anchor for the main content. If not,
          // default to #page-content.
          var $mc = $('#main-content', context).length;
    Severity: Major
    Found in themes/stanford_basic/src/js/stanford_basic.behavior.js - About 2 hrs to fix

      Function MainMenu has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const MainMenu = ({}) => {
        useWebComponentEvents(islandName)
      
        const [menuItems, setMenuItems] = useState<MenuContentItem[]>([]);
        const [menuOpen, setMenuOpen] = useState<boolean>(false);
      Severity: Major
      Found in themes/stanford_basic/decoupled-menu/src/main-menu.island.tsx - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          $form['options_settings']['stanford_basic_browser_sync']['browser_sync']['port'] = [
            '#type' => 'number',
            '#title' => t('Enable BrowserSync support for theme'),
            '#default_value' => theme_get_setting('browser_sync.port'),
            '#description' => t("Default: '3000'."),
        Severity: Major
        Found in themes/stanford_basic/theme-settings.php and 1 other location - About 2 hrs to fix
        themes/stanford_basic/theme-settings.php on lines 211..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 91.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          $form['options_settings']['stanford_basic_browser_sync']['browser_sync']['host'] = [
            '#type' => 'textfield',
            '#title' => t('BrowserSync host'),
            '#default_value' => theme_get_setting('browser_sync.host'),
            '#description' => t("Default: localhost. Enter 'HOST' which will be replaced by your site's hostname."),
        Severity: Major
        Found in themes/stanford_basic/theme-settings.php and 1 other location - About 2 hrs to fix
        themes/stanford_basic/theme-settings.php on lines 221..229

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 91.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function buildCssLayersFromEntryPoints has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const buildCssLayersFromEntryPoints = () => {
          return islands.map(({ layer, elementName }) => {
            return {
              issuerLayer: layer,
              use: [
        Severity: Minor
        Found in themes/stanford_basic/decoupled-menu/webpack.config.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            handleDesktop() {
          
              if (drupalSettings.stanford_basic.nav_dropdown_enabled) {
                this.handleMobile();
                return;
          themes/stanford_basic/src/js/components/multi-menu/buttons/events/OnArrowRightLV1.js on lines 14..26

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            handleDesktop() {
          
              if (drupalSettings.stanford_basic.nav_dropdown_enabled) {
                this.handleMobile();
                return;
          themes/stanford_basic/src/js/components/multi-menu/buttons/events/OnArrowLeftLV1.js on lines 14..26

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method runTask has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            public function runTask(array &$install_state) {
              $this->state->set('nobots', FALSE);
          
              $node_pages = [
                '403_page' => '4b8018dc-49a6-4018-9c54-e8c3e462beee',
          Severity: Minor
          Found in src/Plugin/InstallTask/SiteSettings.php - About 1 hr to fix

            Avoid excessively long variable names like $dependency_definition. Keep variable name length under 20.
            Open

                  $dependency_definition = $this->getDefinition($dependency);
            Severity: Minor
            Found in src/InstallTaskManager.php by phpmd

            LongVariable

            Since: 0.2

            Detects when a field, formal or local variable is declared with a long name.

            Example

            class Something {
                protected $reallyLongIntName = -3; // VIOLATION - Field
                public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
                    $otherReallyLongName = -5; // VIOLATION - Local
                    for ($interestingIntIndex = 0; // VIOLATION - For
                         $interestingIntIndex < 10;
                         $interestingIntIndex++ ) {
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#longvariable

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

              protected function getFeedback() {
                $help = '<h3>' . $this->t('Do you have feedback for us?') . '</h3>';
                $help .= '<p>' . $this->t('Submit Feedback to our Drupal service through our ServiceNow form') . '</p>';
                $help .= self::getLinkString($this->t('Stanford Web Services ServiceNow Form'), 'https://stanford.service-now.com/it_services?id=sc_cat_item&sys_id=83daed294f4143009a9a97411310c70a', TRUE);
                return ['#markup' => $help];
            Severity: Major
            Found in src/Plugin/HelpSection/ProfileHelpSection.php and 4 other locations - About 1 hr to fix
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 41..46
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 54..60
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 87..92
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 113..118

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

              protected function getUserGuide() {
                $help = '<h3>' . $this->t('Stanford Sites User Guide') . '</h3>';
                $help .= '<p>' . $this->t('Everything you need to know about how to use, maintain, and launch your Website.') . '</p>';
                $help .= self::getLinkString($this->t('User Guide'), 'https://sitesuserguide.stanford.edu', TRUE);
                return ['#markup' => $help];
            Severity: Major
            Found in src/Plugin/HelpSection/ProfileHelpSection.php and 4 other locations - About 1 hr to fix
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 54..60
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 87..92
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 100..105
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 113..118

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

              protected function getAssistance() {
                $help = '<h3>' . $this->t('Need assistance?') . '</h3>';
                $help .= '<p>' . $this->t('Submit a ServiceNow request to Stanford Web Services to request assistance with your website.') . '</p>';
                $help .= self::getLinkString($this->t('Stanford Web Services ServiceNow Form'), 'https://stanford.service-now.com/it_services?id=sc_cat_item&sys_id=83daed294f4143009a9a97411310c70a', TRUE);
                return ['#markup' => $help];
            Severity: Major
            Found in src/Plugin/HelpSection/ProfileHelpSection.php and 4 other locations - About 1 hr to fix
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 41..46
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 54..60
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 100..105
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 113..118

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

              protected function getLaunchWebsite() {
                $help = '<h3>' . $this->t('Ready to Launch?') . '</h3>';
                // @TODO: Update link when launch process guide is available.
                $help .= '<p>' . $this->t('Learn about the launch process, review the final checklist, and submit a request to launch.') . '</p>';
                $help .= self::getLinkString($this->t('Website launch process'), 'https://sitesuserguide.stanford.edu/support/site-launch-checklist', TRUE);
            Severity: Major
            Found in src/Plugin/HelpSection/ProfileHelpSection.php and 4 other locations - About 1 hr to fix
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 41..46
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 87..92
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 100..105
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 113..118

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

              protected function getContact() {
                $help = '<h3>' . $this->t("Can't find what you're looking for?") . '</h3>';
                $help .= '<p>' . $this->t("We'll help you find the answer or connect you with an advisor.") . '</p>';
                $help .= self::getLinkString($this->t('Stanford Web Services ServiceNow Form'), 'https://stanford.service-now.com/it_services?id=sc_cat_item&sys_id=83daed294f4143009a9a97411310c70a', TRUE);
                return ['#markup' => $help];
            Severity: Major
            Found in src/Plugin/HelpSection/ProfileHelpSection.php and 4 other locations - About 1 hr to fix
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 41..46
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 54..60
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 87..92
            src/Plugin/HelpSection/ProfileHelpSection.php on lines 100..105

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 84.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            export default class OnEnter extends EventAbstract {
            
              /**
               * Execute the action to the event.
               */
            themes/stanford_basic/src/js/components/secondary-nav/common/events/OnSpace.js on lines 8..19

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              newNavItem(item, depth, parent) {
                var opts = Object.assign(this.options, {depth: depth});
                var nav = new SecondaryNavItem(
                  item,
                  this,
            themes/stanford_basic/src/js/components/multi-menu/buttons/MultiMenuButtons.js on lines 44..54

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              newParentItem(item, depth, parent) {
                var opts = Object.assign(this.options, {depth: depth});
                var nav = new MultiSubNavButtons(
                  item,
                  this,
            themes/stanford_basic/src/js/components/secondary-nav/accordion/SecondaryNavAccordion.js on lines 77..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            export default class OnSpace extends EventAbstract {
            
              /**
               * Execute the action to the event.
               */
            themes/stanford_basic/src/js/components/secondary-nav/common/events/OnEnter.js on lines 8..19

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language