SU-SWS/stanford_actions

Method buildConfigurationForm has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Wontfix

  public function buildConfigurationForm(array $form, FormStateInterface $form_state): array {
    $values = range(1, 10);
    $form['clone_count'] = [
      '#type' => 'select',
      '#title' => $this->t('Clone how many times'),

Avoid using undefined variables such as '$node_ids' which will lead to PHP notices.

Open

      $node_ids[] = $item[0];

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Avoid using undefined variables such as '$node_ids' which will lead to PHP notices.

Open

      ->loadMultiple($node_ids);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

The class CloneNode has a coupling between objects value of 22. Consider to reduce the number of dependencies under 13.

Open

class CloneNode extends ViewsBulkOperationsActionBase implements PluginFormInterface, ContainerFactoryPluginInterface {

  /**
   * {@inheritdoc}
   */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

syntax error, unexpected 'protected' (T_PROTECTED), expecting variable (T_VARIABLE)

Invalid

  public function __construct(array $configuration, $plugin_id, $plugin_definition, protected EntityFieldManagerInterface $entityFieldManager, protected EntityTypeManagerInterface $entityTypeManager, protected FieldCloneManagerInterface $fieldCloneManager, ConfigFactoryInterface $config_factory, protected AccountProxyInterface $currentUser, protected EventDispatcherInterface $eventDispatcher) {

• Exclude checks
  • Disable engine
  • Disable check

Expected 1 space after FUNCTION keyword; 0 found

Wontfix

    return array_filter($fields, function($field) use ($clone_target_types) {

• Exclude checks
  • Disable engine
  • Disable check

Parameter $original_title is not described in comment

Wontfix

  /**

• Exclude checks
  • Disable engine
  • Disable check