Sign upLogin

SU-SWS/stanford_migrate

View on GitHub
Star

Showing 3 of 136 total issues

Function deleteEntityFromMigration has a Cognitive Complexity of 20 (exceeds 10 allowed). Consider refactoring.
Open

  public function deleteEntityFromMigration(EntityInterface $entity): void {
    foreach ($this->getMigrationList() as $migrations) {
      foreach ($migrations as $migration) {
        $destination = $migration->getDestinationConfiguration();
Severity: Minor
Found in src/StanfordMigrate.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buildForm has 56 lines of code (exceeds 40 allowed). Consider refactoring.
Open

  public function buildForm(array $form, FormStateInterface $form_state) {
    $form = parent::buildForm($form, $form_state);
    $migration_id = $this->entity->id();
    $template_link = Link::fromTextAndUrl($this->t('empty CSV template'), $this->entity->toUrl('csv-template'))
      ->toString();
Severity: Major
Found in src/Form/StanfordMigrateCsvImportForm.php - About 1 hr to fix

    Function getNodesMigration has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
    Open

      public function getNodesMigration(NodeInterface $node): ?MigrationEntityInterface {
    // Use a static variable so that it doesn't look up the migrations multiple
    // times.
    $node_migration = &drupal_static(__CLASS__ . __FUNCTION__ . '_' . $node->id());
    Severity: Minor
    Found in src/StanfordMigrate.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language