SU-SWS/stanford_migrate

View on GitHub

Showing 62 of 136 total issues

Function deleteEntityFromMigration has a Cognitive Complexity of 20 (exceeds 10 allowed). Consider refactoring.
Open

  public function deleteEntityFromMigration(EntityInterface $entity): void {
    foreach ($this->getMigrationList() as $migrations) {
      foreach ($migrations as $migration) {
        $destination = $migration->getDestinationConfiguration();

Severity: Minor
Found in src/StanfordMigrate.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid excessively long variable names like $batchExecuteMigrations. Keep variable name length under 20.
Open

  protected $batchExecuteMigrations = FALSE;
Severity: Minor
Found in src/StanfordMigrate.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $migrationPluginManager. Keep variable name length under 20.
Open

  public function __construct(protected EntityTypeManagerInterface $entityTypeManager, protected MigrationPluginManagerInterface $migrationPluginManager, LoggerChannelFactoryInterface $logger_factory) {
Severity: Minor
Found in src/StanfordMigrate.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Method buildForm has 56 lines of code (exceeds 40 allowed). Consider refactoring.
Open

  public function buildForm(array $form, FormStateInterface $form_state) {
    $form = parent::buildForm($form, $form_state);
    $migration_id = $this->entity->id();
    $template_link = Link::fromTextAndUrl($this->t('empty CSV template'), $this->entity->toUrl('csv-template'))
      ->toString();
Severity: Major
Found in src/Form/StanfordMigrateCsvImportForm.php - About 1 hr to fix

    Avoid using undefined variables such as '$row' which will lead to PHP notices.
    Open

        $row['imported']['#markup'] = $migration->getIdMap()->importedCount();

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$row' which will lead to PHP notices.
    Open

          $row['last_imported']['#markup'] = $this->t('Unknown');

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$events' which will lead to PHP notices.
    Open

        return $events;

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$row' which will lead to PHP notices.
    Open

          $row['last_imported']['#markup'] = $this->dateFormatter->format($last_imported / 1000, 'custom', 'M j Y g:i a');

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$row' which will lead to PHP notices.
    Open

        $row['label']['#markup'] = $migration->label();

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$row' which will lead to PHP notices.
    Open

        $row['operations']['data'] = [

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$events' which will lead to PHP notices.
    Open

        $events[MigrateEvents::POST_IMPORT] = ['postImport'];

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$row' which will lead to PHP notices.
    Open

        return $row;

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$row' which will lead to PHP notices.
    Open

        $row['status']['#markup'] = $migration->getStatusLabel();

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    The class StanfordMigrateCsvImportForm has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
    Open

    class StanfordMigrateCsvImportForm extends EntityForm {
    
      /**
       * Migration plugin instance that matches the migration entity.
       *

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
        /**
         * @var \foo\bar\X
         */
        private $x = null;
    
        /**
         * @var \foo\bar\Y
         */
        private $y = null;
    
        /**
         * @var \foo\bar\Z
         */
        private $z = null;
    
        public function setFoo(\Foo $foo) {}
        public function setBar(\Bar $bar) {}
        public function setBaz(\Baz $baz) {}
    
        /**
         * @return \SplObjectStorage
         * @throws \OutOfRangeException
         * @throws \InvalidArgumentException
         * @throws \ErrorException
         */
        public function process(\Iterator $it) {}
    
        // ...
    }

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    The class StanfordMigrate has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13.
    Open

    class StanfordMigrate implements StanfordMigrateInterface {
    
      use MessengerTrait;
    
      /**
    Severity: Minor
    Found in src/StanfordMigrate.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
        /**
         * @var \foo\bar\X
         */
        private $x = null;
    
        /**
         * @var \foo\bar\Y
         */
        private $y = null;
    
        /**
         * @var \foo\bar\Z
         */
        private $z = null;
    
        public function setFoo(\Foo $foo) {}
        public function setBar(\Bar $bar) {}
        public function setBaz(\Baz $baz) {}
    
        /**
         * @return \SplObjectStorage
         * @throws \OutOfRangeException
         * @throws \InvalidArgumentException
         * @throws \ErrorException
         */
        public function process(\Iterator $it) {}
    
        // ...
    }

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Missing parameter comment
    Open

       * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entityTypeManager
    Severity: Minor
    Found in src/StanfordMigrate.php by phpcodesniffer

    Expected 1 blank line after function; 2 found
    Open

      }
    Severity: Minor
    Found in src/StanfordMigrate.php by phpcodesniffer

    Line exceeds 80 characters; contains 82 characters
    Open

          // CSV Imported content can be ignored since it's normally a one time thing.
    Severity: Minor
    Found in src/StanfordMigrate.php by phpcodesniffer

    Line exceeds 80 characters; contains 108 characters
    Open

      // Oauth2 authentication adds a token query parameter into the data urls that changes frequently. Since it
    Severity: Minor
    Found in stanford_migrate.module by phpcodesniffer

    Missing short description in doc comment
    Open

      /**
    Severity: Minor
    Found in src/StanfordMigrate.php by phpcodesniffer
    Severity
    Category
    Status
    Source
    Language