Sign upLogin

SU-SWS/stanford_news

View on GitHub
Star

Showing 1 of 19 total issues

Avoid assigning values to variables in if clauses and the like (line '15', column '7').
Open

function stanford_news_install() {
  // Disable the core taxonomy_term view if it is enabled.
  if ($tax_view = View::load('taxonomy_term')) {
    $tax_view->disable()->save();
  }
Severity: Minor
Found in stanford_news.install by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Severity
Category
Status
Source
Language