Sign upLogin

SU-SWS/stanford_profile

View on GitHub
Star
themes/stanford_basic/theme-settings.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Method stanford_basic_form_system_theme_settings_alter has 210 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function stanford_basic_form_system_theme_settings_alter(array &$form, FormStateInterface $form_state) {

  $form['options_settings'] = [
    '#type' => 'fieldset',
    '#title' => t('Theme Specific Settings'),
Severity: Major
Found in themes/stanford_basic/theme-settings.php - About 1 day to fix

    The function stanford_basic_form_system_theme_settings_alter() has 233 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

    function stanford_basic_form_system_theme_settings_alter(array &$form, FormStateInterface $form_state) {

  $form['options_settings'] = [
    '#type' => 'fieldset',
    '#title' => t('Theme Specific Settings'),
    Severity: Minor
    Found in themes/stanford_basic/theme-settings.php by phpmd

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      $form['options_settings']['stanford_basic_browser_sync']['browser_sync']['port'] = [
    '#type' => 'number',
    '#title' => t('Enable BrowserSync support for theme'),
    '#default_value' => theme_get_setting('browser_sync.port'),
    '#description' => t("Default: '3000'."),
    Severity: Major
    Found in themes/stanford_basic/theme-settings.php and 1 other location - About 2 hrs to fix
    themes/stanford_basic/theme-settings.php on lines 227..235

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      $form['options_settings']['stanford_basic_browser_sync']['browser_sync']['host'] = [
    '#type' => 'textfield',
    '#title' => t('BrowserSync host'),
    '#default_value' => theme_get_setting('browser_sync.host'),
    '#description' => t("Default: localhost. Enter 'HOST' which will be replaced by your site's hostname."),
    Severity: Major
    Found in themes/stanford_basic/theme-settings.php and 1 other location - About 2 hrs to fix
    themes/stanford_basic/theme-settings.php on lines 237..245

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There must be no blank line following an inline comment
    Open

    // @codeCoverageIgnoreStart
    Severity: Minor
    Found in themes/stanford_basic/theme-settings.php by phpcodesniffer

    Missing file doc comment
    Open

    <?php
    Severity: Minor
    Found in themes/stanford_basic/theme-settings.php by phpcodesniffer

    Object operator not indented correctly; expected 4 spaces but found 6
    Wontfix

          ->getPath('stanford_basic') . '/dist/assets/img/lockup-example.png" />';
    Severity: Minor
    Found in themes/stanford_basic/theme-settings.php by phpcodesniffer

    There must be no blank line following an inline comment
    Wontfix

    // @codeCoverageIgnoreEnd
    Severity: Minor
    Found in themes/stanford_basic/theme-settings.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status