Sign upLogin

SU-SWS/stanford_profile_helper

View on GitHub
Star

Showing 521 of 706 total issues

Identical blocks of code found in 5 locations. Consider refactoring.
Open

var webpackConfig = {
  entry: entryPoints,
  output: {
    path: config.distFolder,
    filename: '[name].js',
Severity: Major
Found in modules/stanford_basic_page_types/webpack.config.js and 4 other locations - About 1 day to fix
modules/stanford_intranet/webpack.config.js on lines 32..101
modules/stanford_profile_admin/webpack.config.js on lines 32..101
modules/stanford_profile_styles/webpack.config.js on lines 32..101
modules/stanford_publication/webpack.config.js on lines 32..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 334.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

var webpackConfig = {
  entry: entryPoints,
  output: {
    path: config.distFolder,
    filename: '[name].js',
Severity: Major
Found in modules/stanford_publication/webpack.config.js and 4 other locations - About 1 day to fix
modules/stanford_basic_page_types/webpack.config.js on lines 32..101
modules/stanford_intranet/webpack.config.js on lines 32..101
modules/stanford_profile_admin/webpack.config.js on lines 32..101
modules/stanford_profile_styles/webpack.config.js on lines 32..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 334.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

var webpackConfig = {
  entry: entryPoints,
  output: {
    path: config.distFolder,
    filename: '[name].js',
Severity: Major
Found in modules/stanford_intranet/webpack.config.js and 4 other locations - About 1 day to fix
modules/stanford_basic_page_types/webpack.config.js on lines 32..101
modules/stanford_profile_admin/webpack.config.js on lines 32..101
modules/stanford_profile_styles/webpack.config.js on lines 32..101
modules/stanford_publication/webpack.config.js on lines 32..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 334.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

var webpackConfig = {
  entry: entryPoints,
  output: {
    path: config.distFolder,
    filename: '[name].js',
Severity: Major
Found in modules/stanford_profile_styles/webpack.config.js and 4 other locations - About 1 day to fix
modules/stanford_basic_page_types/webpack.config.js on lines 32..101
modules/stanford_intranet/webpack.config.js on lines 32..101
modules/stanford_profile_admin/webpack.config.js on lines 32..101
modules/stanford_publication/webpack.config.js on lines 32..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 334.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

var webpackConfig = {
  entry: entryPoints,
  output: {
    path: config.distFolder,
    filename: '[name].js',
Severity: Major
Found in modules/stanford_profile_admin/webpack.config.js and 4 other locations - About 1 day to fix
modules/stanford_basic_page_types/webpack.config.js on lines 32..101
modules/stanford_intranet/webpack.config.js on lines 32..101
modules/stanford_profile_styles/webpack.config.js on lines 32..101
modules/stanford_publication/webpack.config.js on lines 32..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 334.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

const entryPoints = glob.sync('./lib/scss/**/*.scss').reduce((acc, filePath) => {
  const filePathParts = filePath.replace('./lib/scss/', '').split('/');
  let fileName = filePathParts.pop();
  if (fileName.indexOf('_') === 0) {
    return acc;
Severity: Major
Found in modules/stanford_intranet/webpack.config.js and 3 other locations - About 6 hrs to fix
modules/stanford_basic_page_types/webpack.config.js on lines 18..30
modules/stanford_profile_admin/webpack.config.js on lines 18..30
modules/stanford_profile_styles/webpack.config.js on lines 18..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 177.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

const entryPoints = glob.sync('./lib/scss/**/*.scss').reduce((acc, filePath) => {
  const filePathParts = filePath.replace('./lib/scss', '').split('/');
  let fileName = filePathParts.pop();
  if (fileName.indexOf('_') === 0) {
    return acc;
Severity: Major
Found in modules/stanford_basic_page_types/webpack.config.js and 3 other locations - About 6 hrs to fix
modules/stanford_intranet/webpack.config.js on lines 18..30
modules/stanford_profile_admin/webpack.config.js on lines 18..30
modules/stanford_profile_styles/webpack.config.js on lines 18..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 177.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

const entryPoints = glob.sync('./lib/scss/**/*.scss').reduce((acc, filePath) => {
  const filePathParts = filePath.replace('./lib/scss/', '').split('/');
  let fileName = filePathParts.pop();
  if (fileName.indexOf('_') === 0) {
    return acc;
Severity: Major
Found in modules/stanford_profile_admin/webpack.config.js and 3 other locations - About 6 hrs to fix
modules/stanford_basic_page_types/webpack.config.js on lines 18..30
modules/stanford_intranet/webpack.config.js on lines 18..30
modules/stanford_profile_styles/webpack.config.js on lines 18..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 177.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

const entryPoints = glob.sync('./lib/scss/**/*.scss').reduce((acc, filePath) => {
  const filePathParts = filePath.replace('./lib/scss/', '').split('/');
  let fileName = filePathParts.pop();
  if (fileName.indexOf('_') === 0) {
    return acc;
Severity: Major
Found in modules/stanford_profile_styles/webpack.config.js and 3 other locations - About 6 hrs to fix
modules/stanford_basic_page_types/webpack.config.js on lines 18..30
modules/stanford_intranet/webpack.config.js on lines 18..30
modules/stanford_profile_admin/webpack.config.js on lines 18..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 177.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function EventCalendar has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const EventCalendar = () => {
  const apiUrl = (process.env?.LOCAL_DRUPAL ?? '') + '/jsonapi/node/stanford_event';
  const nextButtonRef = useRef<HTMLButtonElement>(null);

  const [events, setEvents] = useState<EventNode[]>([])
Severity: Major
Found in modules/stanford_events/pdb_components/mini-calendar/src/event-calendar.island.tsx - About 4 hrs to fix

    File event-calendar.island.tsx has 289 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import {createIslandWebComponent} from 'preact-island'
import {useCallback, useEffect, useRef, useState} from "preact/compat";
import {DrupalJsonApiParams} from "drupal-jsonapi-params";
import styled from "styled-components";
import Jsona from "jsona";
    Severity: Minor
    Found in modules/stanford_events/pdb_components/mini-calendar/src/event-calendar.island.tsx - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          $element['_other']['organization'] = [
      '#type' => 'select',
      '#title' => $this->t("Organization"),
      '#field_parents' => ['other'],
      '#empty_option' => $this->t("- Select Organization -"),
      Severity: Major
      Found in modules/stanford_events/modules/stanford_events_importer/src/Plugin/Field/FieldWidget/StanfordEventsImporterAPIURLFieldWidget.php and 1 other location - About 2 hrs to fix
      modules/stanford_events/modules/stanford_events_importer/src/Plugin/Field/FieldWidget/StanfordEventsImporterAPIURLFieldWidget.php on lines 103..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          $element['_other']['category'] = [
      '#type' => 'select',
      '#title' => $this->t("Category"),
      '#field_parents' => ['other'],
      '#empty_option' => $this->t("- Select Category -"),
      Severity: Major
      Found in modules/stanford_events/modules/stanford_events_importer/src/Plugin/Field/FieldWidget/StanfordEventsImporterAPIURLFieldWidget.php and 1 other location - About 2 hrs to fix
      modules/stanford_events/modules/stanford_events_importer/src/Plugin/Field/FieldWidget/StanfordEventsImporterAPIURLFieldWidget.php on lines 89..101

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method form has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public function form(array $form, FormStateInterface $form_state) {
    $form = parent::form($form, $form_state);

    $citation_type = $this->entity;
    $form['label'] = [
      Severity: Major
      Found in modules/stanford_publication/src/Form/CitationTypeForm.php - About 2 hrs to fix

        Method formElement has 61 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public function formElement(FieldItemListInterface $items, $delta, array $element, array &$form, FormStateInterface $form_state) {

    // De-falt.
    $element = parent::formElement($items, $delta, $element, $form, $form_state);
    $element['#attached']['library'][] = 'core/drupal.states';
        Severity: Major
        Found in modules/stanford_events/modules/stanford_events_importer/src/Plugin/Field/FieldWidget/StanfordEventsImporterAPIURLFieldWidget.php - About 2 hrs to fix

          Method getTypes has 57 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            public function getTypes(): array {
    $types = [];

    $types[] = new ObjectType([
      'name' => $this->getPluginId(),
          Severity: Major
          Found in modules/stanford_decoupled/src/Plugin/GraphQLCompose/SchemaType/ImageType.php - About 2 hrs to fix

            Method getTypes has 48 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              public function getTypes(): array {
    $types = [];

    $types[] = new ObjectType([
      'name' => $this->getPluginId(),
            Severity: Minor
            Found in modules/stanford_decoupled/src/Plugin/GraphQLCompose/SchemaType/BookLink.php - About 1 hr to fix

              Function EventCalendar has a Cognitive Complexity of 20 (exceeds 10 allowed). Consider refactoring.
              Open

              const EventCalendar = () => {
  const apiUrl = (process.env?.LOCAL_DRUPAL ?? '') + '/jsonapi/node/stanford_event';
  const nextButtonRef = useRef<HTMLButtonElement>(null);

  const [events, setEvents] = useState<EventNode[]>([])
              Severity: Minor
              Found in modules/stanford_events/pdb_components/mini-calendar/src/event-calendar.island.tsx - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getBibliography has 44 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                public function getBibliography($style = self::APA): string {

    $data = [
      'id' => $this->id(),
      'title' => $this->label(),
              Severity: Minor
              Found in modules/stanford_publication/src/Entity/Citation.php - About 1 hr to fix

                Identical blocks of code found in 12 locations. Consider refactoring.
                Open

                const config = {
  isProd: process.env.NODE_ENV === "production",
  hmrEnabled: process.env.NODE_ENV !== "production" && !process.env.NO_HMR,
  distFolder: path.resolve(__dirname, "./dist/css"),
  wdsPort: 3001,
                Severity: Major
                Found in modules/stanford_publication/webpack.config.js and 11 other locations - About 1 hr to fix
                modules/stanford_basic_page_types/webpack.config.js on lines 11..16
                modules/jumpstart_ui/webpack.config.js on lines 11..16
                modules/stanford_courses/webpack.config.js on lines 11..16
                modules/stanford_events/webpack.config.js on lines 12..17
                modules/stanford_intranet/webpack.config.js on lines 11..16
                modules/stanford_layout_paragraphs/webpack.config.js on lines 11..16
                modules/stanford_news/webpack.config.js on lines 11..16
                modules/stanford_notifications/webpack.config.js on lines 11..16
                modules/stanford_person/webpack.config.js on lines 11..16
                modules/stanford_profile_admin/webpack.config.js on lines 11..16
                modules/stanford_profile_styles/webpack.config.js on lines 11..16

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 75.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language