Sign upLogin

SUSE/Portus

View on GitHub
Star
app/controllers/auth/omniauth_callbacks_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method github_member? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def github_member?(conf)
    if conf["team"].present?
      # Get user's teams.
      is_member = member_of("https://api.github.com/user/teams") do |t|
        t["name"] == conf["team"] &&
Severity: Minor
Found in app/controllers/auth/omniauth_callbacks_controller.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_membership has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def check_membership
    conf = APP_CONFIG["oauth"][action_name]

    case action_name
    when "github"
Severity: Minor
Found in app/controllers/auth/omniauth_callbacks_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_user has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def check_user
    data = omniauth_data
    unless data
      redirect_to new_user_session_url
      return
Severity: Minor
Found in app/controllers/auth/omniauth_callbacks_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status