Showing 11 of 33 total issues

Method handle_exceptions has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def handle_exceptions
      yield
    rescue RMT::Deduplicator::HardlinkException => e
      raise RMT::CLI::Error.new(
        _('Could not create deduplication hardlink: %{error}.') % { error: e.message },
Severity: Major
Found in lib/rmt/cli/base.rb - About 2 hrs to fix

    Method change_product has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def change_product(target, set_enabled, all_modules)
        # rubocop:disable Lint/ParenthesesAsGroupedExpression
    
        # This will return multiple products if 'SLES/15' was used
        base_products = find_products(target)
    Severity: Minor
    Found in lib/rmt/cli/products.rb - About 1 hr to fix

      Method create_product has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def create_product(item, root_product_id = nil, base_product = nil, recommended = false, migration_extra = false)
      Severity: Minor
      Found in lib/rmt/scc.rb - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def to_csv
            data = @repositories.map do |repo|
              [
                repo.id,
                repo.name,
        Severity: Minor
        Found in lib/rmt/cli/decorators/custom_repository_decorator.rb and 1 other location - About 35 mins to fix
        lib/rmt/cli/decorators/repository_decorator.rb on lines 7..25

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def to_csv
            data = @repositories.map do |repo|
              [
                repo.scc_id,
                repo.name,
        Severity: Minor
        Found in lib/rmt/cli/decorators/repository_decorator.rb and 1 other location - About 35 mins to fix
        lib/rmt/cli/decorators/custom_repository_decorator.rb on lines 7..25

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method list_repositories has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
        Open

          def list_repositories(scope: :enabled)
            repositories = ((scope == :all) ? Repository.only_scc : Repository.only_scc.only_mirrored).order(:name, :description)
            decorator = ::RMT::CLI::Decorators::RepositoryDecorator.new(repositories)
        
            if repositories.empty?
        Severity: Minor
        Found in lib/rmt/cli/repos.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method dispatch has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
        Open

            def dispatch(command, given_args, given_opts, config)
              handle_exceptions { super(command, given_args, given_opts, config) }
            rescue RMT::CLI::Error => e
              warn e.to_s
              if config[:shell]&.base&.options&.[]('debug')
        Severity: Minor
        Found in lib/rmt/cli/base.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method list has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
        Open

          def list
            products = (options.all ? Product.all : Product.mirrored).order(:name, :version, :arch)
            products = products.with_release_stage(options[:release_stage])
            decorator = ::RMT::CLI::Decorators::ProductDecorator.new(products)
        
        
        Severity: Minor
        Found in lib/rmt/cli/products.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def to_table
            data = @products.map do |product|
              [
                product.id,
                product.name,
        Severity: Minor
        Found in lib/rmt/cli/decorators/custom_repository_products_decorator.rb and 1 other location - About 20 mins to fix
        lib/rmt/cli/decorators/custom_repository_products_decorator.rb on lines 7..21

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def to_csv
            data = @products.map do |product|
              [
                product.id,
                product.name,
        Severity: Minor
        Found in lib/rmt/cli/decorators/custom_repository_products_decorator.rb and 1 other location - About 20 mins to fix
        lib/rmt/cli/decorators/custom_repository_products_decorator.rb on lines 24..38

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 27.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        TODO found
        Open

            # TODO: For APIv5 and future. We skip this check for second level extensions. E.g. HA-GEO
        Severity
        Category
        Status
        Source
        Language