Sign upLogin

SUSE/saptune

View on GitHub
Star
sap/note/sectLogin.go

Summary

Maintainability
A
3 hrs
Test Coverage
B
81%

Function SetLoginVal has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
Open

func SetLoginVal(key, value string, revert bool) error {
    switch key {
    case "UserTasksMax":
        system.DebugLog("SetLoginVal - key is '%s', value is '%s', revert is '%v'\n", key, value, revert)
        // because of systemd problems during shutting down a node,
Severity: Minor
Found in sap/note/sectLogin.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function SetLoginVal has 7 return statements (exceeds 4 allowed).
Open

func SetLoginVal(key, value string, revert bool) error {
    switch key {
    case "UserTasksMax":
        system.DebugLog("SetLoginVal - key is '%s', value is '%s', revert is '%v'\n", key, value, revert)
        // because of systemd problems during shutting down a node,
Severity: Major
Found in sap/note/sectLogin.go - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status