SUSE/stratos

View on GitHub

Showing 1,395 of 1,395 total issues

Function validate has a Cognitive Complexity of 21 (exceeds 8 allowed). Consider refactoring.
Open

  private validate(endpoints: EndpointModel[], cluster: KubeConfigFileCluster, clusters: KubeConfigFileCluster[]) {
    cluster._invalid = false;
    let reset = true;

    const found = endpoints.find(item => item.name === cluster.name);

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setActive has a Cognitive Complexity of 21 (exceeds 8 allowed). Consider refactoring.
Open

  setActive(index: number) {
    if (this.basePreviousRedirect && index < 0) {
      this.dispatchRedirect(this.basePreviousRedirect);
    }
    if (!this.canGoto(index)) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getColors has a Cognitive Complexity of 21 (exceeds 8 allowed). Consider refactoring.
Open

  private getColors(total: number, used: number) {
    const percentage = (used / total) * 100;
    // I'm sure this can be tidies up - NJ
    if (this.thresholds) {
      if (this.thresholds.hasOwnProperty('danger')) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File cnsi.go has 517 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package main

import (
    "crypto/x509"
    "encoding/json"
Severity: Minor
Found in src/jetstream/cnsi.go - About 2 hrs to fix

    Function setupSpaceLevelTest has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function setupSpaceLevelTest(
          selectAddRemove: (rb: RadioGroup) => void,
          checkInitialState: () => void,
          checkFinishingState: () => void) {
          it('Check initial state and get to stepper', () => {

      Function constructor has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor(
          gitSCMService: GitSCMService,
          activatedRoute: ActivatedRoute,
          private fb: FormBuilder,
          private snackBarService: SnackBarService,

        Function ngOnInit has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          ngOnInit() {
            if (this.setUsernames) {
              this.blocked.next(false);
            } else {
              this.cfRolesService.loading$.subscribe(loading => this.blocked.next(loading));

          Function ngOnInit has 60 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            ngOnInit() {
              this.sourceType$ = this.store.select(selectSourceType);
          
              // Set previously supplied docker values
              this.subs.push(this.store.select(selectDeployAppState).pipe(

            Method CFHosting.Init has 84 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (ch *CFHosting) Init() error {
            
                // Determine if we are running CF by presence of env var "VCAP_APPLICATION" and configure appropriately
                if ch.portalProxy.Env().IsSet(VCapApplication) {
                    log.Info("Detected that Console is deployed as a Cloud Foundry Application")
            Severity: Major
            Found in src/jetstream/plugins/cloudfoundryhosting/main.go - About 2 hrs to fix

              Method PgsqlTokenRepository.findCNSIToken has 84 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func (p *PgsqlTokenRepository) findCNSIToken(cnsiGUID string, userGUID string, encryptionKey []byte, includeDisconnected bool) (interfaces.TokenRecord, error) {
                  log.Debug("findCNSIToken")
                  if cnsiGUID == "" {
                      msg := "Unable to find CNSI Token without a valid CNSI GUID."
                      log.Debug(msg)
              Severity: Major
              Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 2 hrs to fix

                File list.component.spec.ts has 265 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                import { ChangeDetectorRef, NgZone } from '@angular/core';
                import { async, ComponentFixture, inject, TestBed } from '@angular/core/testing';
                import { NoopAnimationsModule } from '@angular/platform-browser/animations';
                import { Store } from '@ngrx/store';
                import { createBasicStoreModule } from '@stratosui/store/testing';

                  File edit-autoscaler-policy-step4.component.ts has 264 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  import { Component, OnInit } from '@angular/core';
                  import { AbstractControl, FormBuilder, FormGroup, ValidatorFn, Validators } from '@angular/forms';
                  import { ErrorStateMatcher, ShowOnDirtyErrorStateMatcher } from '@angular/material/core';
                  import { ActivatedRoute } from '@angular/router';
                  import { Store } from '@ngrx/store';

                    CfUserService has 22 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    @Injectable()
                    export class CfUserService {
                      private allUsers$: Observable<PaginationObservables<APIResource<CfUser>>>;
                    
                      users: { [guid: string]: Observable<APIResource<CfUser>>; } = {};

                      AutoscalerEffects has 22 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      @Injectable()
                      export class AutoscalerEffects {
                        constructor(
                          private http: HttpClient,
                          private actions$: Actions,
                      Severity: Minor
                      Found in src/frontend/packages/cf-autoscaler/src/store/autoscaler.effects.ts - About 2 hrs to fix

                        File application-tabs-base.component.ts has 262 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        import { Component, NgZone, OnDestroy, OnInit } from '@angular/core';
                        import { Store } from '@ngrx/store';
                        import { GitSCMService, GitSCMType } from '@stratosui/git';
                        import { combineLatest as observableCombineLatest, Observable, Subscription } from 'rxjs';
                        import { filter, first, map, startWith, switchMap, withLatestFrom } from 'rxjs/operators';

                          Method Analyzer.doRun has 82 lines of code (exceeds 50 allowed). Consider refactoring.
                          Open

                          func (a *Analyzer) doRun(ec echo.Context) error {
                          
                              log.Debug("Run analyzer!")
                          
                              engine := ec.Param("analyzer")
                          Severity: Major
                          Found in src/jetstream/plugins/analysis/container/run.go - About 2 hrs to fix

                            Function constructor has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                              constructor(
                                public endpointsService: EndpointsService,
                                private store: Store<AppState>,
                                public userFavoriteManager: UserFavoriteManager,
                                private scrollDispatcher: ScrollDispatcher,

                              Method Monocular.procesChartVersions has a Cognitive Complexity of 20 (exceeds 8 allowed). Consider refactoring.
                              Open

                              func (m *Monocular) procesChartVersions(endpoint, repoURL, repoName, name string, chartVersions []IndexFileMetadata) syncResult {
                              
                                  result := syncResult{}
                              
                                  // Find the newest version
                              Severity: Minor
                              Found in src/jetstream/plugins/monocular/sync_worker.go - About 2 hrs to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method cnsiTokenBackup.createBackup has a Cognitive Complexity of 20 (exceeds 8 allowed). Consider refactoring.
                              Open

                              func (ctb *cnsiTokenBackup) createBackup(data *BackupRequest) (*BackupContent, error) {
                                  log.Debug("createBackup")
                                  allEndpoints, err := ctb.p.ListEndpoints()
                                  if err != nil {
                                      return nil, interfaces.NewHTTPShadowError(http.StatusBadGateway, "Failed to fetch endpoints", "Failed to fetch endpoints: %+v", err)
                              Severity: Minor
                              Found in src/jetstream/plugins/backup/backup_restore.go - About 2 hrs to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method HelmRelease.processJsonResource has a Cognitive Complexity of 20 (exceeds 8 allowed). Consider refactoring.
                              Open

                              func (r *HelmRelease) processJsonResource(obj interface{}) {
                                  data, err := json.Marshal(obj)
                                  if err == nil {
                                      var t KubeResource
                                      if err := json.Unmarshal(data, &t); err == nil {
                              Severity: Minor
                              Found in src/jetstream/plugins/kubernetes/helm/release.go - About 2 hrs to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language