Sign upLogin

SUSE/stratos

View on GitHub
Star

Showing 1,395 of 1,395 total issues

Function flattenPagination has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

  actionDispatcher: ActionDispatcher,
  firstRequest: Observable<C>,
  flattener: PaginationFlattener<T, C>,
  maxCount?: number,
  entityType?: string,
Severity: Major
Found in src/frontend/packages/store/src/helpers/paginated-request-helpers.ts - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export class DeleteAppServiceInstancesComponent implements OnDestroy {

  @Output()
  public selected = new EventEmitter<APIResource<IServiceInstance>[]>();
    Severity: Major
    Found in src/frontend/packages/cloud-foundry/src/features/applications/application-delete/delete-app-instances/delete-app-instances.component.ts and 1 other location - About 1 hr to fix
    src/frontend/packages/cloud-foundry/src/features/applications/application-delete/delete-app-routes/delete-app-routes.component.ts on lines 20..39

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 210.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    export class DeleteAppRoutesComponent implements OnDestroy {

  @Output()
  public selected = new EventEmitter<APIResource<IServiceBinding>[]>();
    Severity: Major
    Found in src/frontend/packages/cloud-foundry/src/features/applications/application-delete/delete-app-routes/delete-app-routes.component.ts and 1 other location - About 1 hr to fix
    src/frontend/packages/cloud-foundry/src/features/applications/application-delete/delete-app-instances/delete-app-instances.component.ts on lines 20..39

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 210.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method cnsiTokenBackup.restoreBackup has 9 return statements (exceeds 4 allowed).
    Open

    func (ctb *cnsiTokenBackup) restoreBackup(backup *RestoreRequest) error {
    log.Debug("restoreBackup")

    data := &BackupContent{}
    if err := json.Unmarshal([]byte(backup.Data), data); err != nil {
    Severity: Major
    Found in src/jetstream/plugins/backup/backup_restore.go - About 55 mins to fix

      Method KubernetesSpecification.InstallRelease has 9 return statements (exceeds 4 allowed).
      Open

      func (c *KubernetesSpecification) InstallRelease(ec echo.Context) error {
    bodyReader := ec.Request().Body
    buf := new(bytes.Buffer)
    buf.ReadFrom(bodyReader)
      Severity: Major
      Found in src/jetstream/plugins/kubernetes/install_release.go - About 55 mins to fix

        Function makePrometheusRequestURI has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
        Open

        func makePrometheusRequestURI(c echo.Context, prometheusOp string, modify string) *url.URL {
    uri := getEchoURL(c)
    uri.Path = "/api/v1/" + prometheusOp
    values := uri.Query()
    query := values.Get("query")
        Severity: Minor
        Found in src/jetstream/plugins/metrics/cloud_foundry.go - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method MetricsSpecification.Connect has 9 return statements (exceeds 4 allowed).
        Open

        func (m *MetricsSpecification) Connect(ec echo.Context, cnsiRecord interfaces.CNSIRecord, userId string) (*interfaces.TokenRecord, bool, error) {
    log.Debug("Metrics Connect...")

    params := new(interfaces.LoginToCNSIParams)
    err := interfaces.BindOnce(params, ec)
        Severity: Major
        Found in src/jetstream/plugins/metrics/main.go - About 55 mins to fix

          Method KubeTerminal.Start has 9 return statements (exceeds 4 allowed).
          Open

          func (k *KubeTerminal) Start(c echo.Context) error {
    log.Debug("Kube Terminal start request")

    endpointGUID := c.Param("guid")
    userGUID := c.Get("user_id").(string)
          Severity: Major
          Found in src/jetstream/plugins/kubernetes/terminal/start.go - About 55 mins to fix

            Method Analysis.checkStatus has 9 return statements (exceeds 4 allowed).
            Open

            func (c *Analysis) checkStatus() error {
    log.Debug("Checking status....")
    p := c.portalProxy
    // Create a record in the reports datastore
    dbStore, err := store.NewAnalysisDBStore(p.GetDatabaseConnection())
            Severity: Major
            Found in src/jetstream/plugins/analysis/status.go - About 55 mins to fix

              Method Monocular.cleanCacheFiles has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
              Open

              func (m *Monocular) cleanCacheFiles(endpointID string, allCharts []store.ChartStoreRecord) error {

    // Build map of the valid chart folder names
    validFiles := make(map[string]bool)
    for _, chart := range allCharts {
              Severity: Minor
              Found in src/jetstream/plugins/monocular/cache.go - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method UaaUserInfo.uaa has 9 return statements (exceeds 4 allowed).
              Open

              func (userInfo *UaaUserInfo) uaa(target string, body []byte) (int, []byte, *http.Header, error) {
    log.Debug("uaa request")

    // Check session
    _, err := userInfo.portalProxy.GetSessionInt64Value(userInfo.echo, "exp")
              Severity: Major
              Found in src/jetstream/plugins/userinfo/uaa_user.go - About 55 mins to fix

                Method PgsqlTokenRepository.SaveAuthToken has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
                Open

                func (p *PgsqlTokenRepository) SaveAuthToken(userGUID string, tr interfaces.TokenRecord, encryptionKey []byte) error {
    log.Debug("SaveAuthToken")
    if userGUID == "" {
        msg := "Unable to save Auth Token without a valid User GUID."
        log.Debug(msg)
                Severity: Minor
                Found in src/jetstream/repository/tokens/pgsql_tokens.go - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method portalProxy.updateEndpoint has 9 return statements (exceeds 4 allowed).
                Open

                func (p *portalProxy) updateEndpoint(ec echo.Context) error {
    log.Debug("updateEndpoint")

    params := new(interfaces.UpdateEndpointParams)
    if err := ec.Bind(params); err != nil {
                Severity: Major
                Found in src/jetstream/cnsi.go - About 55 mins to fix

                  Method portalProxy.verifySession has 9 return statements (exceeds 4 allowed).
                  Open

                  func (p *portalProxy) verifySession(c echo.Context) error {
    log.Debug("verifySession")

    p.StratosAuthService.BeforeVerifySession(c)
                  Severity: Major
                  Found in src/jetstream/session.go - About 55 mins to fix

                    Function endpointActions has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
                    Open

                      endpointActions(includeSeparators = false): IListAction<EndpointModel>[] {
    // Add any additional actions that are per endpoint type
    const customActions = entityCatalog.getAllEndpointTypes()
      .map(endpoint => endpoint.definition.endpointListActions)
      .filter(endpointListActions => !!endpointListActions)
                    Severity: Minor
                    Found in src/frontend/packages/core/src/shared/components/list/list-types/endpoint/endpoint-list.helpers.ts - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function sortEndpointTiles has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
                    Open

                      protected sortEndpointTiles(
    { label: aLabel, renderPriority: aRenderPriority }: IStratosEndpointDefinition,
    { label: bLabel, renderPriority: bRenderPriority }: IStratosEndpointDefinition
  ) {
    // We're going to do a little more work than just to compare the render priority to ensure
                    Severity: Minor
                    Found in src/frontend/packages/core/src/features/endpoints/create-endpoint/create-endpoint-base-step/base-endpoint-tile-manager.ts - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function makeSpan has a Cognitive Complexity of 12 (exceeds 8 allowed). Consider refactoring.
                    Open

                      makeSpan() {
    let span = '';
    if (this.boldOn || this.currentFg || this.currentBg) {
      span += '<span class="';
      if (this.boldOn) {
                    Severity: Minor
                    Found in src/frontend/packages/core/src/shared/components/log-viewer/ansi-colors.ts - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method CFAppPush.getConfigData has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func (cfAppPush *CFAppPush) getConfigData(echoContext echo.Context, cnsiGUID string, orgGUID string, spaceGUID string, spaceName string, orgName string, clientWebSocket *websocket.Conn) (*CFPushAppConfig, error) {
                    Severity: Major
                    Found in src/jetstream/plugins/cfapppush/deploy.go - About 50 mins to fix

                      Function normalize has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      var normalize = function normalize(schema, input, parent, key, visit, addEntity, visitedEntities) {
                      Severity: Major
                      Found in src/frontend/packages/store/src/normalizr/normalizr.js - About 50 mins to fix

                        Function setUpTestOrgSpaceUserRoles has 7 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                          cfGuid: string,
  defaultCf: E2EConfigCloudFoundry,
  orgName: string,
  spaceName: string,
  userName: string,
                        Severity: Major
                        Found in src/test-e2e/cloud-foundry/users-list-e2e.helper.ts - About 50 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language