SUSE/stratos

View on GitHub
src/jetstream/repository/cnsis/pgsql_cnsis.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method PostgresCNSIRepository.List has a Cognitive Complexity of 17 (exceeds 8 allowed). Consider refactoring.
Open

func (p *PostgresCNSIRepository) List(encryptionKey []byte) ([]*interfaces.CNSIRecord, error) {
    log.Debug("List")
    rows, err := p.db.Query(listCNSIs)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
Severity: Minor
Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method PostgresCNSIRepository.ListByUser has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
Open

func (p *PostgresCNSIRepository) ListByUser(userGUID string) ([]*interfaces.ConnectedEndpoint, error) {
    log.Debug("ListByUser")
    rows, err := p.db.Query(listCNSIsByUser, "cnsi", userGUID)
    if err != nil {
        return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
Severity: Minor
Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method PostgresCNSIRepository.Update has 6 return statements (exceeds 4 allowed).
Open

func (p *PostgresCNSIRepository) Update(endpoint interfaces.CNSIRecord, encryptionKey []byte) error {
    log.Debug("Update endpoint")

    if endpoint.GUID == "" {
        msg := "Unable to update Endpoint without a valid guid."
Severity: Major
Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 40 mins to fix

    Method PostgresCNSIRepository.List has 6 return statements (exceeds 4 allowed).
    Open

    func (p *PostgresCNSIRepository) List(encryptionKey []byte) ([]*interfaces.CNSIRecord, error) {
        log.Debug("List")
        rows, err := p.db.Query(listCNSIs)
        if err != nil {
            return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
    Severity: Major
    Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 40 mins to fix

      Method PostgresCNSIRepository.ListByUser has 5 return statements (exceeds 4 allowed).
      Open

      func (p *PostgresCNSIRepository) ListByUser(userGUID string) ([]*interfaces.ConnectedEndpoint, error) {
          log.Debug("ListByUser")
          rows, err := p.db.Query(listCNSIsByUser, "cnsi", userGUID)
          if err != nil {
              return nil, fmt.Errorf("Unable to retrieve CNSI records: %v", err)
      Severity: Major
      Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 35 mins to fix

        Method PostgresCNSIRepository.UpdateMetadata has 5 return statements (exceeds 4 allowed).
        Open

        func (p *PostgresCNSIRepository) UpdateMetadata(guid string, metadata string) error {
            log.Debug("UpdateMetadata")
        
            if guid == "" {
                msg := "Unable to update Endpoint without a valid guid."
        Severity: Major
        Found in src/jetstream/repository/cnsis/pgsql_cnsis.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status