Sign upLogin

Sage/device_wizard

View on GitHub
Star
lib/device_wizard/user_agent_detector.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
93%

Method determine_type has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Wontfix

    def determine_type(user_agent)
      return DeviceType::TABLET if user_agent.include? TABLET

      if user_agent.include? MOBILE
        if user_agent.include? IPAD
Severity: Minor
Found in lib/device_wizard/user_agent_detector.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Wontfix

      return DeviceType::MOBILE if REGEX_MOBILE =~ user_agent
Severity: Major
Found in lib/device_wizard/user_agent_detector.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Wontfix

          return DeviceType::CRAWLER if REGEX_CRAWLER =~ user_agent
    Severity: Major
    Found in lib/device_wizard/user_agent_detector.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Wontfix

            return DeviceType::DESKTOP if REGEX_OS =~ user_agent
      Severity: Major
      Found in lib/device_wizard/user_agent_detector.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Wontfix

              return DeviceType::TABLET if user_agent.include? SILK
        Severity: Major
        Found in lib/device_wizard/user_agent_detector.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status