Sage/sinject

View on GitHub

Showing 4 of 4 total issues

Method register has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def register(options = {}, &initialize_block)
      raise Sinject::DependencyRegistrationKeyNotSpecifiedException.new unless options.has_key?(:key)

      raise Sinject::DependencyRegistrationClassNotSpecifiedException.new unless options.has_key?(:class)

Severity: Minor
Found in lib/sinject/container.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_contract has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_contract(dependency_class, contract_class)
      # get the methods defined for the contract
      contract_methods = (contract_class.instance_methods - Object.instance_methods)
      # get the methods defined for the dependency
      dependency_methods = (dependency_class.instance_methods - Object.instance_methods)
Severity: Minor
Found in lib/sinject/container.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_contract has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def validate_contract(dependency_class, contract_class)
      # get the methods defined for the contract
      contract_methods = (contract_class.instance_methods - Object.instance_methods)
      # get the methods defined for the dependency
      dependency_methods = (dependency_class.instance_methods - Object.instance_methods)
Severity: Minor
Found in lib/sinject/container.rb - About 1 hr to fix

    Method get has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def get(key)
          # get the dependency from the container store for the specified key
          item = @store[key]
          if !item.nil?
            # check if the item has been registered as a single instance item.
    Severity: Minor
    Found in lib/sinject/container.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language