Sign upLogin

Saibamen/HotelManager

View on GitHub
Star
app/Services/GuestTableService.php

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Method getColumns has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getColumns()
    {
        $dataset = [
            [
                'title' => trans('general.first_name'),
Severity: Minor
Found in app/Services/GuestTableService.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return $dataset;
    Severity: Major
    Found in app/Services/GuestTableService.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return $data->contact;
      Severity: Major
      Found in app/Services/GuestTableService.php - About 30 mins to fix

        Define a constant instead of duplicating this literal "value" 5 times.
        Open

                        'value' => function (Guest $data) {
        Severity: Critical
        Found in app/Services/GuestTableService.php by sonar-php

        Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

        On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

        Noncompliant Code Example

        With the default threshold of 3:

        function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

        Compliant Solution

        ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

        Exceptions

        To prevent generating some false-positives, literals having less than 5 characters are excluded.

        Define a constant instead of duplicating this literal "title" 5 times.
        Open

                        'title' => trans('general.first_name'),
        Severity: Critical
        Found in app/Services/GuestTableService.php by sonar-php

        Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

        On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

        Noncompliant Code Example

        With the default threshold of 3:

        function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

        Compliant Solution

        ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

        Exceptions

        To prevent generating some false-positives, literals having less than 5 characters are excluded.

        There are no issues that match your filters.

        Category
        Status