Saibamen/HotelManager

Method getFields has 40 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getFields($forAdd = false)
    {
        return [
            [
                'id'    => 'date_start',

Method chooseFreeRoom has 36 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function chooseFreeRoom(RoomTableService $roomTableService, $guestId)
    {
        if (!$this->isReservationDataInSessionCorrect()) {
            return $this->returnBack([
                'message'     => trans('general.session_error'),

Avoid using short method names like CreateGuestsTable::up(). The configured minimum method name length is 3.

Open

    public function up()
    {
        Schema::create('guests', function (Blueprint $table) {
            $table->increments('id');
            $table->string('first_name', 35);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Avoid using short method names like CreateRoomsTable::up(). The configured minimum method name length is 3.

Open

    public function up()
    {
        Schema::create('rooms', function (Blueprint $table) {
            $table->increments('id');
            $table->string('number', 5);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Avoid using short method names like CreateReservationsTable::up(). The configured minimum method name length is 3.

Open

    public function up()
    {
        Schema::create('reservations', function (Blueprint $table) {
            $table->increments('id');
            $table->integer('room_id')->unsigned();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Avoid using short method names like CreateUsersTable::up(). The configured minimum method name length is 3.

Open

    public function up()
    {
        Schema::create('users', function (Blueprint $table) {
            $table->increments('id');
            $table->string('name');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Avoid using short method names like CreatePasswordResetsTable::up(). The configured minimum method name length is 3.

Open

    public function up()
    {
        Schema::create('password_resets', function (Blueprint $table) {
            $table->string('email')->index();
            $table->string('token');

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Method getColumns has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getColumns()
    {
        $dataset = [
            [
                'title' => trans('general.first_name'),

Method getColumns has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getColumns()
    {
        $dataset = [
            [
                'title' => trans('general.room'),

Method getColumns has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getColumns()
    {
        $dataset = [
            [
                'title' => trans('general.number'),

Method editChangeRoom has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function editChangeRoom($reservationId, $roomId)
    {
        try {
            $reservation = Reservation::select('id', 'people', 'date_start', 'date_end')
                ->findOrFail($reservationId);

Method getActionButtons has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getActionButtons()
    {
        return [
            'id'         => 'action_buttons',
            'type'       => 'buttons',

Method editChooseRoom has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function editChooseRoom(RoomTableService $roomTableService, $reservationId)
    {
        try {
            $reservation = Reservation::select('id', 'guest_id', 'date_start', 'date_end', 'people')
                ->findOrFail($reservationId);

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (typeof $(modal.relatedTarget).data("href") !== 'undefined') {
            window.deleteHref = $(modal.relatedTarget).data("href");
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if (typeof $(modal.relatedTarget).data("id") !== 'undefined') {
            window.deleteId = $(modal.relatedTarget).data("id");
        }

• Read up
  Read up

Method getInitialStateFields has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function getInitialStateFields()
    {
        return [
            [
                'id'    => 'rooms',

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class UsersTableSeeder extends Seeder

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class CreateReservationsTable extends Migration

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class DatabaseSeeder extends Seeder

• Exclude checks
  • Disable engine
  • Disable check

Each class must be in a namespace of at least one level (a top-level vendor name)

Open

class CreateGuestsTable extends Migration

• Exclude checks
  • Disable engine
  • Disable check