Sign upLogin

Schwad/mara

View on GitHub
Star

Showing 8 of 8 total issues

Method run has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def run
        # The goal here is to automatically find  the optimal C and gamma values
        # for a Gaussian SVM kernel. Currently an 80-line method 'script' that could benefit from some refactoring, comparing with 'run_with_c_and_gamma' not very 'dry'. Also with bigger data could do with plenty of optimization. Cover with tests and measure performance first.

        # Adapted from: https://github.com/daugaard/example-svm
Severity: Major
Found in app/models/machine_learning/strategies/svm.rb - About 2 hrs to fix

    Method run has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def run
        # The goal here is to automatically find  the optimal C and gamma values
        # for a Gaussian SVM kernel. Currently an 80-line method 'script' that could benefit from some refactoring, comparing with 'run_with_c_and_gamma' not very 'dry'. Also with bigger data could do with plenty of optimization. Cover with tests and measure performance first.

        # Adapted from: https://github.com/daugaard/example-svm
    Severity: Minor
    Found in app/models/machine_learning/strategies/svm.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run_with_c_and_gamma has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def run_with_c_and_gamma(predicted_c, predicted_gamma)
        # The goal here is to automatically find  the optimal C and gamma values
        # for a Gaussian SVM kernel

        # Adapted from: https://github.com/daugaard/example-svm
    Severity: Minor
    Found in app/models/machine_learning/strategies/svm.rb - About 1 hr to fix

      Method call has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def call
    context.incoming_message = context.message.get_command_for(context.bot)
    return if context.message.location
    if context&.incoming_message&.split(" ")[0].downcase == 'signup'
      if User.where(friendly_name: context.message.from.username).count > 0
      Severity: Minor
      Found in app/interactors/signup_user.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method call has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def call
    context.incoming_message = context.message.get_command_for(context.bot)
    return if context.message.location
    if context&.incoming_message&.split(" ")[0].downcase == 'signup'
      if User.where(friendly_name: context.message.from.username).count > 0
      Severity: Minor
      Found in app/interactors/signup_user.rb - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    correct = predicted.collect.with_index do |e,i|
              if (e.to_f - validation_y_data[i].to_f).magnitude <= @magnitude
                1
              else
                0
        Severity: Minor
        Found in app/models/machine_learning/strategies/svm.rb and 2 other locations - About 15 mins to fix
        app/models/machine_learning/strategies/svm.rb on lines 129..135
        app/models/machine_learning/strategies/svm.rb on lines 191..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                correct = predicted.collect.with_index do |e,i|
          if (e.to_f - test_y_data[i].to_f).magnitude <= @magnitude
            1
          else
            0
        Severity: Minor
        Found in app/models/machine_learning/strategies/svm.rb and 2 other locations - About 15 mins to fix
        app/models/machine_learning/strategies/svm.rb on lines 91..97
        app/models/machine_learning/strategies/svm.rb on lines 191..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                correct = predicted.collect.with_index do |e,i|
          if (e.to_f - test_y_data[i].to_f).magnitude <= @magnitude
            1
          else
            0
        Severity: Minor
        Found in app/models/machine_learning/strategies/svm.rb and 2 other locations - About 15 mins to fix
        app/models/machine_learning/strategies/svm.rb on lines 91..97
        app/models/machine_learning/strategies/svm.rb on lines 129..135

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language