SciRuby/distribution

View on GitHub
lib/distribution/bivariatenormal/ruby.rb

Summary

Maintainability
D
1 day
Test Coverage

Method cdf_genz has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def cdf_genz(x, y, rho)
          dh = -x
          dk = -y
          r = rho
          twopi = 6.283185307179586
Severity: Major
Found in lib/distribution/bivariatenormal/ruby.rb - About 4 hrs to fix

    Method cdf_genz has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

            def cdf_genz(x, y, rho)
              dh = -x
              dk = -y
              r = rho
              twopi = 6.283185307179586
    Severity: Minor
    Found in lib/distribution/bivariatenormal/ruby.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method cdf_hull has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def cdf_hull(a, b, rho)
              # puts "a:#{a} - b:#{b} - rho:#{rho}"
              if a <= 0 && b <= 0 && rho <= 0
                # puts "ruta 1"
                aprime = a.quo(Math.sqrt(2.0 * (1.0 - rho**2)))
    Severity: Minor
    Found in lib/distribution/bivariatenormal/ruby.rb - About 1 hr to fix

      Method cdf_jantaravareerat has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              def cdf_jantaravareerat(x, y, rho, s1 = 1, s2 = 1)
                # Special cases
                return 1 if x > LIMIT && y > LIMIT
                return 0 if x < -LIMIT || y < -LIMIT
                return Distribution::Normal.cdf(y) if  x > LIMIT
      Severity: Minor
      Found in lib/distribution/bivariatenormal/ruby.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method cdf_hull has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

              def cdf_hull(a, b, rho)
                # puts "a:#{a} - b:#{b} - rho:#{rho}"
                if a <= 0 && b <= 0 && rho <= 0
                  # puts "ruta 1"
                  aprime = a.quo(Math.sqrt(2.0 * (1.0 - rho**2)))
      Severity: Minor
      Found in lib/distribution/bivariatenormal/ruby.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method pdf has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def pdf(x, y, rho, s1 = 1.0, s2 = 1.0)
      Severity: Minor
      Found in lib/distribution/bivariatenormal/ruby.rb - About 35 mins to fix

        Method f has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def f(x, y, aprime, bprime, rho)
        Severity: Minor
        Found in lib/distribution/bivariatenormal/ruby.rb - About 35 mins to fix

          Method cdf_jantaravareerat has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def cdf_jantaravareerat(x, y, rho, s1 = 1, s2 = 1)
          Severity: Minor
          Found in lib/distribution/bivariatenormal/ruby.rb - About 35 mins to fix

            Avoid too many return statements within this method.
            Open

                        return cdf(a, 0.0, rho1) + cdf(b, 0.0, rho2) - delta
            Severity: Major
            Found in lib/distribution/bivariatenormal/ruby.rb - About 30 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                        (1..6).each do|i|
                          w[i][2] = data[(i - 1) * 2]
                          x[i][2] = data[(i - 1) * 2 + 1]
              Severity: Minor
              Found in lib/distribution/bivariatenormal/ruby.rb and 2 other locations - About 25 mins to fix
              lib/distribution/bivariatenormal/ruby.rb on lines 159..161
              lib/distribution/bivariatenormal/ruby.rb on lines 186..188

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 31.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                        (1..3).each do|i|
                          w[i][1] = data[(i - 1) * 2]
                          x[i][1] = data[(i - 1) * 2 + 1]
              Severity: Minor
              Found in lib/distribution/bivariatenormal/ruby.rb and 2 other locations - About 25 mins to fix
              lib/distribution/bivariatenormal/ruby.rb on lines 170..172
              lib/distribution/bivariatenormal/ruby.rb on lines 186..188

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 31.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                        (1..10).each do|i|
                          w[i][3] = data[(i - 1) * 2]
                          x[i][3] = data[(i - 1) * 2 + 1]
              Severity: Minor
              Found in lib/distribution/bivariatenormal/ruby.rb and 2 other locations - About 25 mins to fix
              lib/distribution/bivariatenormal/ruby.rb on lines 159..161
              lib/distribution/bivariatenormal/ruby.rb on lines 170..172

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 31.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status