SciRuby/minimization

View on GitHub

Showing 28 of 28 total issues

Method brent_iterate has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    def brent_iterate
      x_left = @x_lower;
      x_right = @x_upper;

      z = @x_minimum;
Severity: Minor
Found in lib/minimization.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find_root has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    def find_root(lower_bound, upper_bound, f)
      @f = f
      lower  = lower_bound
      f_upper = f(lower_bound)
      upper  = upper_bound
Severity: Minor
Found in lib/multidim/brent_root_finder.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File minimization.rb has 344 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require_relative 'multidim/brent_root_finder'
require_relative 'multidim/conjugate_gradient'
require_relative 'multidim/nelder_mead'
require_relative 'multidim/point_value_pair'
require_relative 'multidim/powell'
Severity: Minor
Found in lib/minimization.rb - About 4 hrs to fix

    Method brent_iterate has 86 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def brent_iterate
          x_left = @x_lower;
          x_right = @x_upper;
    
          z = @x_minimum;
    Severity: Major
    Found in lib/minimization.rb - About 3 hrs to fix

      Method check_parameters has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          def check_parameters
            if (!@start.nil?)
              dim = @start.length
              if (!@lower_bound.nil?)
                # check for dimension mismatches
      Severity: Minor
      Found in lib/multidim/powell.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method find_root has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def find_root(lower_bound, upper_bound, f)
            @f = f
            lower  = lower_bound
            f_upper = f(lower_bound)
            upper  = upper_bound
      Severity: Major
      Found in lib/multidim/brent_root_finder.rb - About 2 hrs to fix

        Method iterate has 67 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def iterate 
              @iterations += 1
        
              # set initial configurations
              if(@iterations <= 1)
        Severity: Major
        Found in lib/multidim/powell.rb - About 2 hrs to fix

          Method iterate_simplex has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def iterate_simplex
                increment_iterations_counter
                n = @simplex.length - 1
                # the simplex has n+1 point if dimension is n
                best       = @simplex[0]
          Severity: Major
          Found in lib/multidim/nelder_mead.rb - About 2 hrs to fix

            Method bracketing has 60 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def bracketing
                  eval_max=10
                  f_left = @f_lower;
                  f_right = @f_upper;
                  x_left = @x_lower;
            Severity: Major
            Found in lib/minimization.rb - About 2 hrs to fix

              Method iterate_simplex has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  def iterate_simplex
                    increment_iterations_counter
                    n = @simplex.length - 1
                    # the simplex has n+1 point if dimension is n
                    best       = @simplex[0]
              Severity: Minor
              Found in lib/multidim/nelder_mead.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method iterate has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def iterate
                    ax=@lower
                    bx=@expected
                    cx=@upper
                    c = (3-Math::sqrt(5)).quo(2);
              Severity: Minor
              Found in lib/minimization.rb - About 1 hr to fix

                Method iterate has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def iterate
                      @iterations  += 1
                      @previous     = @current
                      @current      = Minimization::PointValuePair.new(@point, f(@point))
                      # set converging parameter
                Severity: Minor
                Found in lib/multidim/conjugate_gradient.rb - About 1 hr to fix

                  Method check_parameters has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      def check_parameters
                        if (!@start.nil?)
                          dim = @start.length
                          if (!@lower_bound.nil?)
                            # check for dimension mismatches
                  Severity: Minor
                  Found in lib/multidim/powell.rb - About 1 hr to fix

                    Method iterate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def iterate
                          ax=@lower
                          bx=@expected
                          cx=@upper
                          c = (3-Math::sqrt(5)).quo(2);
                    Severity: Minor
                    Found in lib/minimization.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method bracketing has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def bracketing
                          eval_max=10
                          f_left = @f_lower;
                          f_right = @f_upper;
                          x_left = @x_lower;
                    Severity: Minor
                    Found in lib/minimization.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                              xc = Array.new(n)
                              # perform an outside contraction
                              0.upto(n - 1) do |j|
                                xc[j] = centroid[j] + @gamma * (xr[j] - centroid[j])
                              end
                    Severity: Minor
                    Found in lib/multidim/nelder_mead.rb and 1 other location - About 55 mins to fix
                    lib/multidim/nelder_mead.rb on lines 300..311

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 44.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                              xc = Array.new(n)
                              # perform an inside contraction
                              0.upto(n - 1) do |j|
                                xc[j] = centroid[j] - @gamma * (centroid[j] - x_worst[j])
                              end
                    Severity: Minor
                    Found in lib/multidim/nelder_mead.rb and 1 other location - About 55 mins to fix
                    lib/multidim/nelder_mead.rb on lines 288..298

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 44.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (!@lower_bound.nil?)
                              # check for dimension mismatches
                              raise "dimension mismatching #{@lower_bound.length} and #{dim}" if @lower_bound.length != dim
                              # check whether start point exeeds the lower bound
                              0.upto(dim - 1) do |i|
                    Severity: Minor
                    Found in lib/multidim/powell.rb and 1 other location - About 45 mins to fix
                    lib/multidim/powell.rb on lines 86..93

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 40.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (!@upper_bound.nil?)
                              # check for dimension mismatches
                              raise "dimension mismatching #{@upper_bound.length} and #{dim}" if @upper_bound.length != dim
                              # check whether strating point exceeds the upper bound
                              0.upto(dim - 1) do |i|
                    Severity: Minor
                    Found in lib/multidim/powell.rb and 1 other location - About 45 mins to fix
                    lib/multidim/powell.rb on lines 76..83

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 40.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method iterate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def iterate 
                          @iterations += 1
                    
                          # set initial configurations
                          if(@iterations <= 1)
                    Severity: Minor
                    Found in lib/multidim/powell.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language