SciRuby/nmatrix

View on GitHub
lib/nmatrix/io/market.rb

Summary

Maintainability
C
1 day
Test Coverage

Method load_coordinate has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def load_coordinate file, converter, dtype, entry_type, symmetry

      mat = nil

      # Read until we get the dimensions and nonzeros
Severity: Minor
Found in lib/nmatrix/io/market.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method save_coordinate has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def save_coordinate matrix, file, symmetry, pattern
      # Convert to a hash in order to store
      rows = matrix.to_h

      # Count non-zeros
Severity: Minor
Found in lib/nmatrix/io/market.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load_coordinate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def load_coordinate file, converter, dtype, entry_type, symmetry

      mat = nil

      # Read until we get the dimensions and nonzeros
Severity: Minor
Found in lib/nmatrix/io/market.rb - About 1 hr to fix

    Method save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def save(matrix, filename, options = {})
          options = {:pattern => false,
            :symmetry => :general}.merge(options)
    
          mode = matrix.stype == :dense ? :array : :coordinate
    Severity: Minor
    Found in lib/nmatrix/io/market.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method load_coordinate has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def load_coordinate file, converter, dtype, entry_type, symmetry
    Severity: Minor
    Found in lib/nmatrix/io/market.rb - About 35 mins to fix

      Method load_array has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def load_array file, converter, dtype, entry_type, symmetry
      Severity: Minor
      Found in lib/nmatrix/io/market.rb - About 35 mins to fix

        Method load_array has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def load_array file, converter, dtype, entry_type, symmetry
              mat = nil
        
              line = file.gets
              line.chomp!
        Severity: Minor
        Found in lib/nmatrix/io/market.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status