Sign upLogin

Sciebo-RDS/py-research-data-services-common

View on GitHub
Star

Showing 15 of 15 total issues

File Service.py has 569 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from .Token import Token, OAuth2Token
from .User import User
from .Informations import LoginMode, FileTransferMode, FileTransferArchive
from urllib.parse import urlparse, urlunparse
import requests
Severity: Major
Found in RDS/Service.py - About 1 day to fix

    Function __init__ has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        def __init__(
        self,
        servicename: str,
        implements: list = None,
        fileTransferMode: FileTransferMode = FileTransferMode.active,
    Severity: Minor
    Found in RDS/Service.py - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Util.py has 259 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import importlib
import json
from .Service import initService, BaseService, LoginService, OAuth2Service
from .User import initUser
from .Token import initToken, Token
    Severity: Minor
    Found in RDS/Util.py - About 2 hrs to fix

      BaseService has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class BaseService:
    """
    Represents a service, which can be used in RDS.
    """
      Severity: Minor
      Found in RDS/Service.py - About 2 hrs to fix

        Function getElement has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            def getElement(self, id: str, doc: dict = None, expand: bool = False, clean: bool = False, clamps: int = None):
        """Gets the element with given id

        Args:
            id (str): The id you are searching for
        Severity: Minor
        Found in RDS/ROParser.py - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __clean has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            def __clean(self, docs, clamps):
        if not isinstance(docs, (dict, list)):
            return docs

        if not isinstance(docs, list):
        Severity: Minor
        Found in RDS/ROParser.py - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function refresh has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            def refresh(self, token: OAuth2Token):
        """
        Refresh the given oauth2 token for specified user.
        """
        Severity: Minor
        Found in RDS/Service.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __init__ has 11 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(
        Severity: Major
        Found in RDS/Service.py - About 1 hr to fix

          Function internal_load_class has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          def internal_load_class(data: dict):
    """
    For internal use only.
    """
          Severity: Minor
          Found in RDS/Util.py - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(
          Severity: Minor
          Found in RDS/Service.py - About 45 mins to fix

            Function from_service has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def from_service(
            Severity: Minor
            Found in RDS/Service.py - About 35 mins to fix

              Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def __init__(
              Severity: Minor
              Found in RDS/Token.py - About 35 mins to fix

                Function getElement has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def getElement(self, id: str, doc: dict = None, expand: bool = False, clean: bool = False, clamps: int = None):
                Severity: Minor
                Found in RDS/ROParser.py - About 35 mins to fix

                  Function __getRootIdentifier has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def __getRootIdentifier(self):
        for elem in self.__doc["@graph"]:

            if elem["@id"] == "ro-crate-metadata.json":
                version = elem["conformsTo"]["@id"]
                  Severity: Minor
                  Found in RDS/ROParser.py - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function wrap_monkeypatch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def wrap_monkeypatch(fn):
        @wraps(fn)
        def wrapper(*args, **kwargs):
            key = "app"
            if kwargs.get(key) is not None:
                  Severity: Minor
                  Found in RDS/Util.py - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language