Sign upLogin

ScienceToolbox/sciencetoolbox

View on GitHub
Star

Showing 7 of 7 total issues

Method check_health has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_health
    begin
      case provider
      when :bitbucket
        data = JSON.parse RestClient.get "https://bitbucket.org/api/1.0/repositories/#{repo_name}/src/master/"
Severity: Minor
Found in app/models/tool.rb - About 1 hr to fix

    Method check_health has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_health
    begin
      case provider
      when :bitbucket
        data = JSON.parse RestClient.get "https://bitbucket.org/api/1.0/repositories/#{repo_name}/src/master/"
    Severity: Minor
    Found in app/models/tool.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_or_initialize_from_provider_and_username has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.find_or_initialize_from_provider_and_username(provider, username)

    case provider
    when 'github'
      user = User.find_by_nickname_and_provider(username, 'github')
    Severity: Minor
    Found in app/models/user.rb - About 1 hr to fix

      Method find_tools has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def find_tools
    Tool.find_each do |tool|
      case tool.url
      when /github\.com/
        if tool.metadata["owner_login"] == nickname
      Severity: Minor
      Found in app/models/user.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method find_or_initialize_from_provider_and_username has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.find_or_initialize_from_provider_and_username(provider, username)

    case provider
    when 'github'
      user = User.find_by_nickname_and_provider(username, 'github')
      Severity: Minor
      Found in app/models/user.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if @user.persisted?
      sign_in_and_redirect @user, :event => :authentication #this will throw if @user is not activated
      set_flash_message(:notice, :success, :kind => "Bitbucket") if is_navigational_format?
    else
      session["devise.bitbucket_data"] = request.env["omniauth.auth"]
      Severity: Minor
      Found in app/controllers/users/omniauth_callbacks_controller.rb and 1 other location - About 20 mins to fix
      app/controllers/users/omniauth_callbacks_controller.rb on lines 6..11

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if @user.persisted?
      sign_in_and_redirect @user, :event => :authentication
      set_flash_message(:notice, :success, :kind => "GitHub") if is_navigational_format?
    else
      session["devise.github_data"] = request.env["omniauth.auth"]
      Severity: Minor
      Found in app/controllers/users/omniauth_callbacks_controller.rb and 1 other location - About 20 mins to fix
      app/controllers/users/omniauth_callbacks_controller.rb on lines 20..25

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language