Sign upLogin

ScienceToolbox/sciencetoolbox

View on GitHub
Star

Showing 5 of 7 total issues

Method check_health has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_health
    begin
      case provider
      when :bitbucket
        data = JSON.parse RestClient.get "https://bitbucket.org/api/1.0/repositories/#{repo_name}/src/master/"
Severity: Minor
Found in app/models/tool.rb - About 1 hr to fix

    Method check_health has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_health
    begin
      case provider
      when :bitbucket
        data = JSON.parse RestClient.get "https://bitbucket.org/api/1.0/repositories/#{repo_name}/src/master/"
    Severity: Minor
    Found in app/models/tool.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_or_initialize_from_provider_and_username has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.find_or_initialize_from_provider_and_username(provider, username)

    case provider
    when 'github'
      user = User.find_by_nickname_and_provider(username, 'github')
    Severity: Minor
    Found in app/models/user.rb - About 1 hr to fix

      Method find_tools has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def find_tools
    Tool.find_each do |tool|
      case tool.url
      when /github\.com/
        if tool.metadata["owner_login"] == nickname
      Severity: Minor
      Found in app/models/user.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method find_or_initialize_from_provider_and_username has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.find_or_initialize_from_provider_and_username(provider, username)

    case provider
    when 'github'
      user = User.find_by_nickname_and_provider(username, 'github')
      Severity: Minor
      Found in app/models/user.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language