Sign upLogin

SebastianCzoch/onesky-go

View on GitHub
Star

Showing 6 of 36 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func InDeltaSlice(t TestingT, expected, actual interface{}, delta float64, msgAndArgs ...interface{}) bool {
    if expected == nil || actual == nil ||
        reflect.TypeOf(actual).Kind() != reflect.Slice ||
        reflect.TypeOf(expected).Kind() != reflect.Slice {
        return Fail(t, fmt.Sprintf("Parameters must be slice"), msgAndArgs...)
Severity: Major
Found in Godeps/_workspace/src/github.com/stretchr/testify/assert/assertions.go and 1 other location - About 2 hrs to fix
Godeps/_workspace/src/github.com/stretchr/testify/assert/assertions.go on lines 774..792

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 241.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func InEpsilonSlice(t TestingT, expected, actual interface{}, delta float64, msgAndArgs ...interface{}) bool {
    if expected == nil || actual == nil ||
        reflect.TypeOf(actual).Kind() != reflect.Slice ||
        reflect.TypeOf(expected).Kind() != reflect.Slice {
        return Fail(t, fmt.Sprintf("Parameters must be slice"), msgAndArgs...)
Severity: Major
Found in Godeps/_workspace/src/github.com/stretchr/testify/assert/assertions.go and 1 other location - About 2 hrs to fix
Godeps/_workspace/src/github.com/stretchr/testify/assert/assertions.go on lines 719..737

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 241.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func HTTPRedirect(t TestingT, handler http.HandlerFunc, mode, url string, values url.Values) bool {
    code := httpCode(handler, mode, url, values)
    if code == -1 {
        return false
    }
Severity: Minor
Found in Godeps/_workspace/src/github.com/stretchr/testify/assert/http_assertions.go and 1 other location - About 35 mins to fix
Godeps/_workspace/src/github.com/stretchr/testify/assert/http_assertions.go on lines 28..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func HTTPSuccess(t TestingT, handler http.HandlerFunc, mode, url string, values url.Values) bool {
    code := httpCode(handler, mode, url, values)
    if code == -1 {
        return false
    }
Severity: Minor
Found in Godeps/_workspace/src/github.com/stretchr/testify/assert/http_assertions.go and 1 other location - About 35 mins to fix
Godeps/_workspace/src/github.com/stretchr/testify/assert/http_assertions.go on lines 41..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func NewJsonResponse(status int, body interface{}) (*http.Response, error) {
    encoded, err := json.Marshal(body)
    if err != nil {
        return nil, err
    }
Severity: Minor
Found in Godeps/_workspace/src/github.com/jarcoal/httpmock/response.go and 1 other location - About 30 mins to fix
Godeps/_workspace/src/github.com/jarcoal/httpmock/response.go on lines 76..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func NewXmlResponse(status int, body interface{}) (*http.Response, error) {
    encoded, err := xml.Marshal(body)
    if err != nil {
        return nil, err
    }
Severity: Minor
Found in Godeps/_workspace/src/github.com/jarcoal/httpmock/response.go and 1 other location - About 30 mins to fix
Godeps/_workspace/src/github.com/jarcoal/httpmock/response.go on lines 54..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language