Semantic-Org/Semantic-UI-Ember

View on GitHub

Showing 29 of 29 total issues

Avoid deeply nested control flow statements.
Open

            if (this.areAttrValuesEqual('selected', value, module)) {
              equal = true;
              break;
            }
Severity: Major
Found in addon/components/ui-dropdown.js - About 45 mins to fix

    Avoid too many return statements within this function.
    Open

        return this.areAttrValuesEqual('selected', selectedValue, moduleValue);
    Severity: Major
    Found in addon/components/ui-dropdown.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return this.execute('set disabled');
      Severity: Major
      Found in addon/mixins/checkbox.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return true; // We found a match, just looking for one
        Severity: Major
        Found in addon/components/ui-dropdown.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return this.execute('set enabled');
          Severity: Major
          Found in addon/mixins/checkbox.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return this.$().toggleClass('read-only', attrValue);
            Severity: Major
            Found in addon/mixins/checkbox.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return false;
              Severity: Major
              Found in addon/components/ui-dropdown.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return this._super(...arguments);
                Severity: Major
                Found in addon/mixins/checkbox.js - About 30 mins to fix

                  Function _checkValueAndCurrent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    _checkValueAndCurrent(hash) {
                      let isChecked = this.execute('is checked');
                      if (this.areAttrValuesEqual('checked', hash.value, hash.current)) {
                        // Value and current match, but radio isn't checked, return false
                        if (!isChecked) {
                  Severity: Minor
                  Found in addon/components/ui-radio.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language