Sign upLogin

Send-Tribute/tribute-utils

View on GitHub
Star

Showing 10 of 10 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    const newProportions = Object.values(recipientMap).map(value => {
      let val = this._reduceToMaxPrecision(value);
      // reduction of additional powers if the number matches the number
      if (value.eq(recipientBal)) {
        val = val.div(bigNumberify(10).pow(tensDiff));
Severity: Major
Found in src/Tribute.js and 1 other location - About 3 hrs to fix
src/Tribute.js on lines 200..207

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    const newProportions = Object.values(recipientMap).map(value => {
      let val = this._reduceToMaxPrecision(value);
      // reduction of additional powers if the number matches the number
      if (value.eq(recipientBal)) {
        val = val.div(bigNumberify(10).pow(tensDiff));
Severity: Major
Found in src/Tribute.js and 1 other location - About 3 hrs to fix
src/Tribute.js on lines 268..275

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function startFlow has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async startFlow(recipientAddress, amountToFlowString) {
    const DAI_DECIMALS = await this.get_DAI_DECIMALS();

    // decimals length cannot be bigger than allowed DAI_DECIMALS
    const decimalSize = amountToFlowString.split(".")[1].length;
Severity: Major
Found in src/Tribute.js - About 2 hrs to fix

    Function endFlow has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async endFlow(addressToRemove) {
    const DAI_DECIMALS = await this.get_DAI_DECIMALS();

    const balance_BN = await this.rDAIContract.balanceOf(this.userAddress);
    Severity: Minor
    Found in src/Tribute.js - About 1 hr to fix

      Function getInfo has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async getInfo(address) {
    const balance_BN = await this.rDAIContract.balanceOf(address);
    const unclaimedBalance_BN = await this.rDAIContract.interestPayableOf(
      address
    );
      Severity: Minor
      Found in src/Tribute.js - About 1 hr to fix

        Function generate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async generate(amountToTransferString) {
    const DAI_DECIMALS = await this.get_DAI_DECIMALS();

    // decimals length cannot be bigger than allowed DAI_DECIMALS
    const decimalSize = amountToTransferString.split(".")[1].length;
        Severity: Minor
        Found in src/Tribute.js - About 1 hr to fix

          Function startFlow has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            async startFlow(recipientAddress, amountToFlowString) {
    const DAI_DECIMALS = await this.get_DAI_DECIMALS();

    // decimals length cannot be bigger than allowed DAI_DECIMALS
    const decimalSize = amountToFlowString.split(".")[1].length;
          Severity: Minor
          Found in src/Tribute.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            async get_DAI_DECIMALS() {
    if (this.DAI_DECIMALS === null) {
      this.DAI_DECIMALS = await this.DAIContract.decimals();
    }
    return this.DAI_DECIMALS;
          Severity: Minor
          Found in src/Tribute.js and 1 other location - About 55 mins to fix
          src/Tribute.js on lines 25..30

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            async get_rDAI_DECIMALS() {
    if (this.rDAI_DECIMALS === null) {
      this.rDAI_DECIMALS = await this.rDAIContract.decimals();
    }
    return this.rDAI_DECIMALS;
          Severity: Minor
          Found in src/Tribute.js and 1 other location - About 55 mins to fix
          src/Tribute.js on lines 18..23

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function endFlow has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            async endFlow(addressToRemove) {
    const DAI_DECIMALS = await this.get_DAI_DECIMALS();

    const balance_BN = await this.rDAIContract.balanceOf(this.userAddress);
          Severity: Minor
          Found in src/Tribute.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language