Sign upLogin

Sergey-B/project-lvl2-s221

View on GitHub
Star

Showing 11 of 11 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('diff plain output', () => {
  const expectedResult = fs.readFileSync(buildFilePath('nested/plain_result.txt'), 'utf8');
  const outputFormat = 'plain';

  test('diff json with plain output', () => {
Severity: Major
Found in __tests__/diff.test.js and 1 other location - About 6 hrs to fix
__tests__/diff.test.js on lines 56..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('diff json output', () => {
  const expectedResult = fs.readFileSync(buildFilePath('nested/json_result.json'), 'utf8');
  const outputFormat = 'json';

  test('diff json', () => {
Severity: Major
Found in __tests__/diff.test.js and 1 other location - About 6 hrs to fix
__tests__/diff.test.js on lines 39..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('diff nested configs', () => {
  const expectedResult = fs.readFileSync(buildFilePath('nested/result.txt'), 'utf8');

  test('diff nested json', () => {
    expect(gendiff(buildFilePath('nested/before.json'), buildFilePath('nested/after.json'))).toEqual(expectedResult);
Severity: Major
Found in __tests__/diff.test.js and 1 other location - About 6 hrs to fix
__tests__/diff.test.js on lines 7..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 156.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

describe('diff flat configs', () => {
  const expectedResult = fs.readFileSync(buildFilePath('flat/result.txt'), 'utf8');

  test('diff json files', () => {
    expect(gendiff(buildFilePath('flat/before.json'), buildFilePath('flat/after.json'))).toEqual(expectedResult);
Severity: Major
Found in __tests__/diff.test.js and 1 other location - About 6 hrs to fix
__tests__/diff.test.js on lines 23..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 156.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function renderDefault has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

const renderDefault = (ast, depth = 1) => {
  const indentWidth = 4;
  const indent = ' '.repeat(depth * indentWidth);

  const renderValue = (value, d = depth + 1) => {
Severity: Minor
Found in src/renderers/default.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function renderDefault has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const renderDefault = (ast, depth = 1) => {
  const indentWidth = 4;
  const indent = ' '.repeat(depth * indentWidth);

  const renderValue = (value, d = depth + 1) => {
Severity: Minor
Found in src/renderers/default.js - About 1 hr to fix

    Function renderPlain has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    const renderPlain = (ast) => {
  const iter = (acc, pathAcc, node) => {
    const {
      type, name, oldValue, newValue, children,
    } = node;
    Severity: Minor
    Found in src/renderers/plain.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return null;
    Severity: Major
    Found in src/renderers/default.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return `${indent.slice(2)}+ ${name}: ${renderValue(newValue)}`;
      Severity: Major
      Found in src/renderers/default.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return [...acc, {
      type: 'changed', name: key, newValue: obj2[key], oldValue: obj1[key],
    }];
        Severity: Major
        Found in src/index.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return acc;
          Severity: Major
          Found in src/renderers/plain.js - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language