Sergey-B/project-lvl2-s221

View on GitHub

Showing 7 of 11 total issues

Function renderDefault has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

const renderDefault = (ast, depth = 1) => {
  const indentWidth = 4;
  const indent = ' '.repeat(depth * indentWidth);

  const renderValue = (value, d = depth + 1) => {
Severity: Minor
Found in src/renderers/default.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function renderDefault has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const renderDefault = (ast, depth = 1) => {
  const indentWidth = 4;
  const indent = ' '.repeat(depth * indentWidth);

  const renderValue = (value, d = depth + 1) => {
Severity: Minor
Found in src/renderers/default.js - About 1 hr to fix

    Function renderPlain has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    const renderPlain = (ast) => {
      const iter = (acc, pathAcc, node) => {
        const {
          type, name, oldValue, newValue, children,
        } = node;
    Severity: Minor
    Found in src/renderers/plain.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return null;
    Severity: Major
    Found in src/renderers/default.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return `${indent.slice(2)}+ ${name}: ${renderValue(newValue)}`;
      Severity: Major
      Found in src/renderers/default.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return [...acc, {
              type: 'changed', name: key, newValue: obj2[key], oldValue: obj1[key],
            }];
        Severity: Major
        Found in src/index.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return acc;
          Severity: Major
          Found in src/renderers/plain.js - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language